added github-handle variable for Matt Pereira#6365
added github-handle variable for Matt Pereira#6365freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
Review ETA: EOD 2/24/24 |
luisitocanlas
left a comment
There was a problem hiding this comment.
Hi @partapparam,
- Pull request is done with the correct branch.
- The issue is linked properly.
- Pull request has the proper title and content with a single suggestion. The part where it says "Why did you make the changes?" could be more descriptive. A good guide would be to use or reference the Overview from the linked issue, for this case: "We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file."
- Action items from the linked issue were done properly.
- Everything else looks good!
Thank you!
|
Review ETA: EOD 2/25/24 |
|
@partapparam just a suggestion for future PRs in the section |
freaky4wrld
left a comment
There was a problem hiding this comment.
@partapparam thanks for taking up the issue, the branches looks good and the issue is linked correctly...... the changes made are apt.
Fixes #6111
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
Updated variable, no visible changes to the website.