Move program-areas directory and refactor program-areas.html

[luisitocanlas]

Fixes #6323

What changes did you make?

• Moved program-areas directory so it is outside of the _data directory
• Renamed program-areas directory to _program-areas
• Added the following in _config.yml, under the collections variable:

  program-areas:
      output: false
  

• Refactor code in pages/program-areas.html so that it works to pull information from the files in the _program-areas directory
  • removed {% if program_areas[1].size > 0 %} at line 21 and {% endif %} at line 63
  • refactored program_areas[1] into program_areas

Why did you make the changes (we will use this info to test)?

• Per issue:
  • We can use the contents in the files in the program-areas directory for individual program area pages in the future
  • the Program Areas page doesn't break when the program-areas directory is moved
• {% if program_areas[1].size > 0 %} at line 21, {% endif %} at line 63, and program_areas[1] were giving me this error:

  Liquid Exception: 1 is not a symbol nor a string in pages/program-areas.html
  

  • Before moving the program-areas directory, the code with program_areas[1] was working perfectly. Once I moved the program-areas directory outside of the _data directory, that's when I started encountering the error

[github-actions]

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b luisitocanlas-move-refactor-program-areas-6323 gh-pages
git pull https://github.com/luisitocanlas/website.git move-refactor-program-areas-6323

---

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/luisitocanlas/website/blob/move-refactor-program-areas-6323/CONTRIBUTING.md  

[Anahisv23]

Availability: 2/29 - 3/1, 10AM - 5PM
Review ETA: Thursday 2/29 5PM

[Anahisv23]

Hey @luisitocanlas thanks for taking up this issue!

Here's what you did well
• Into and commit branches are correct
• There is a linked issue
• Moved the program-areas directory outside of the data directory
• Renamed the program-areas directory to _program-areas
• Added the appropriate code to _config.yml file
• Refactored the pages/program-areas.html code to retrieve data from the _program-areas directory
• The program areas website page shows the correct data

Overall nice work!

[freaky4wrld]

@luisitocanlas thanks for taking up the issue, the branches looks fine and linked issue is correct too. The changes you made are great as well and docker-testing shows no error.

Thanks for mentioning the error, before merging I would like @t-will-gillis to look into the error, as everything looks fine to me

PR approved

[t-will-gillis]

Hey @luisitocanlas - tl;dr Thanks for mentioning the error, and I agree with your changes and with @freaky4wrld and @Anahisv23- looks great!

Otherwise, I am still learning about Jekyll but I believe this is a difference in Collections vs Data Files.

BTW this is outside of the scope of the issue, but I think it would help clarity by removing the blank lines at lines 60 and 26 and indenting the fors and ifs as shown. Thoughts?

[luisitocanlas]

Hi @Anahisv23 , @freaky4wrld , @t-will-gillis,

I'm also pretty new to Jekyll and I need to read more about that. I also incorporated the changes you recommended, it will definitely help on clarity.

Thank you for all of your feedback!

[t-will-gillis]

Hey @luisitocanlas - Thanks for making the edits!

I will go ahead and merge since @Anahisv23 and @freaky4wrld have already approved this