added github handle to Maxwell Countryman Skewes profile 6180#6438
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
github-actions
bot
added
good first issue
There was a problem hiding this comment.
Hi @aswutmaxcy ,
"github-handle" is spelled incorrectly. The pushed code has "githube".
Please make the corrections and push your code again.
Thank you
edited spelling error on line 92 from "githube-handle:" to "github-handle:"
|
@heejung-hong Thank you for the catch! Just edited the line with the correction. |
heejung-hong
left a comment
heejung-hong
left a comment
There was a problem hiding this comment.
Good work!
The branches are correct and the issue is linked.
The correct file was changed with the correct information.
marioantonini
left a comment
marioantonini
left a comment
There was a problem hiding this comment.
Changes looks good.
Thanks for taking the time to work on this!
t-will-gillis
left a comment
t-will-gillis
left a comment
There was a problem hiding this comment.
Hi @aswutmaxcy - everything looks great with your issue, and thanks for working with @heejung-hong to resolve the changes requested.
I have one more request and it involves the formatting for Markdown in the description section: please edit the text for 'what changes were made and why' by adding a space between the dash and the text explanation, and also by removing the extra dash (in two locations). ie replace:
-added "github-handle"...
-
with:
- added "github-handle"...
Thanks! After that, this PR is ready to merge
|
@t-will-gillis changed the markdown description to copy your comment |
t-will-gillis
left a comment
t-will-gillis
left a comment
There was a problem hiding this comment.
Looks great, thanks @aswutmaxcy!
4 participants
Fixes #6180
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes, just a place to add a github handle in future