github-handle Bonnie - #6167#6448
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
|
@Ayrh1 it seems in your PR description, has no link to the issue you are working on the top of your PR says Also provide an apt description, so that the reviewer has the ease to review it!!! Make sure the rest of the template is followed correctly, a great PR description increases the chances of getting the PR merged. Feel free to look through the CONTRIBUTING GUIDE If this is a draft PR, provide an apt heading saying it's a draft and not to review it!! |
|
Availability: March 13-15, 3pm - 7pm CST |
There was a problem hiding this comment.
Hi @Ayrh1 — great work on this issue!
- You linked the issue correctly in your PR description
- Your branch is correct
- Everything looks good across mobile and desktop
I have a couple of recommendations for your PR description. Can you make the following changes? I adjusted the formatting, pulled some info from the issue ticket and added the "Screenshots of Proposed Changes Of The Website" section back in. It will make it more clear to reviewers and the merge team.
Once you update the description I'll approve. Thanks! 😄
What changes did you make?
Replaced:
- name: Bonnie Wolfe
with
- name: Bonnie Wolfe
github-handle:
On the file _projects/civic-tech-index.md
Why did you make the changes (we will use this info to test)?
We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.
Fixes #6167
What changes did you make?
Replaced:
with
On the file _projects/civic-tech-index.md
Why did you make the changes (we will use this info to test)?
We need to create a single variable
github-handleto hold the github handle for each member of the leadership team. Eventuallygithub-handlewill replace thegithubandpicturevariables, reducing redundancy in the project file.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.