Skip to content

github-handle Bonnie - #6167#6448

Merged
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
Ayrh1:bonnie-guthub0handle-6167
Mar 14, 2024
Merged

github-handle Bonnie - #6167#6448
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
Ayrh1:bonnie-guthub0handle-6167

Conversation

@Ayrh1
Copy link
Member

@Ayrh1 Ayrh1 commented Mar 11, 2024

Fixes #6167

What changes did you make?

Replaced:

- name: Bonnie Wolfe

with

 - name: Bonnie Wolfe
  github-handle:  

On the file _projects/civic-tech-index.md

Why did you make the changes (we will use this info to test)?

We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Ayrh1-bonnie-guthub0handle-6167 gh-pages
git pull https://github.com/Ayrh1/HFLAwebsite.git bonnie-guthub0handle-6167

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Ayrh1/website/blob/bonnie-guthub0handle-6167/CONTRIBUTING.md  

@freaky4wrld
Copy link
Member

freaky4wrld commented Mar 12, 2024

@Ayrh1 it seems in your PR description, has no link to the issue you are working on the top of your PR says Fixes #replace_this_text_with_the_issue_number you have to make it like this Fixes #1234 where the number is the issue number you are working on.

Also provide an apt description, so that the reviewer has the ease to review it!!! Make sure the rest of the template is followed correctly, a great PR description increases the chances of getting the PR merged. Feel free to look through the CONTRIBUTING GUIDE

If this is a draft PR, provide an apt heading saying it's a draft and not to review it!!

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 13, 2024
@gaylem gaylem self-requested a review March 13, 2024 18:30
@gaylem
Copy link
Member

gaylem commented Mar 13, 2024

Availability: March 13-15, 3pm - 7pm CST
Review ETA: 3/13 by 10pm CST

Copy link
Member

@gaylem gaylem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Ayrh1 — great work on this issue!

  • You linked the issue correctly in your PR description
  • Your branch is correct
  • Everything looks good across mobile and desktop

I have a couple of recommendations for your PR description. Can you make the following changes? I adjusted the formatting, pulled some info from the issue ticket and added the "Screenshots of Proposed Changes Of The Website" section back in. It will make it more clear to reviewers and the merge team.

Once you update the description I'll approve. Thanks! 😄


What changes did you make?

Replaced:

- name: Bonnie Wolfe

with

- name: Bonnie Wolfe
  github-handle: 

On the file _projects/civic-tech-index.md

Why did you make the changes (we will use this info to test)?

We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@Ayrh1 Ayrh1 requested a review from gaylem March 13, 2024 21:19
Copy link
Member

@gaylem gaylem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done -- Approved! 👍

@freaky4wrld freaky4wrld self-requested a review March 14, 2024 03:37
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ayrh1 thanks for taking up the issue, the branches looks good, issue linked is correct too. Changes made are apt the description provided is great too.... Thanks @gaylem for providing great suggestions!!!

PR approved!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Bonnie Wolfe in civic-tech-index.md

3 participants