Skip to content

Add github-handle for Aleiya Gafar in brigade-organizers-playbook.md#6456

Closed
Jperparas wants to merge 1 commit intohackforla:gh-pagesfrom
Jperparas:gh-pages
Closed

Add github-handle for Aleiya Gafar in brigade-organizers-playbook.md#6456
Jperparas wants to merge 1 commit intohackforla:gh-pagesfrom
Jperparas:gh-pages

Conversation

@Jperparas
Copy link
Member

Fixes #6154

What changes did you make?

  • added github-handle: under name: Aleiya Gafar in _projects/brigade-organizers-playbook.md

Why did you make the changes (we will use this info to test)?

  • Reduce redundancy

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

-No visual changes to website

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Jperparas-gh-pages gh-pages
git pull https://github.com/Jperparas/website.git gh-pages

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Jperparas/website/blob/gh-pages/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 11, 2024
@colin-macrae colin-macrae self-requested a review March 12, 2024 01:03
@agutiernc agutiernc self-requested a review March 12, 2024 03:28
@agutiernc
Copy link
Member

Availability: 3/12
ETA: EoD 3/12

@colin-macrae
Copy link
Member

colin-macrae commented Mar 12, 2024

Availability: 3/12-14
ETA: 3/14

@agutiernc
Copy link
Member

Thanks your contribution, @Jperparas ! I have one request for a change regarding the branch name:

Other than that, the addition of the github-handle variable looks good. Once you've updated the branch name, I'll be happy to approve.

@Jperparas Jperparas deleted the branch hackforla:gh-pages March 13, 2024 02:14
@Jperparas Jperparas closed this Mar 13, 2024
@Jperparas Jperparas deleted the gh-pages branch March 13, 2024 02:14
@Jperparas
Copy link
Member Author

Thanks your contribution, @Jperparas ! I have one request for a change regarding the branch name:

* Please name your branch to follow the guidelines in [section 2.7.b, of the Contributing doc](https://github.com/hackforla/website/blob/gh-pages/CONTRIBUTING.md#27b-working-on-an-issue-2-create-a-new-branch-where-you-will-work-on-your-issue). The branch name should relate to the issue being addressed and include the issue number.

Other than that, the addition of the github-handle variable looks good. Once you've updated the branch name, I'll be happy to approve.

had to close this to rename branch new pull request at #6457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Aleiya Gafar in brigade-organizers-playbook.md

3 participants