Skip to content

added github-handle under Kevin Phan line27#6465

Merged
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
aswutmaxcy:add-github-handle-6169
Mar 19, 2024
Merged

added github-handle under Kevin Phan line27#6465
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
aswutmaxcy:add-github-handle-6169

Conversation

@aswutmaxcy
Copy link
Member

Fixes #6169

What changes did you make?

  • added "github-handle:" under Kevin Phan on ln 27 in _projects/civic-tech-index.md

Why did you make the changes (we will use this info to test)?

  • make changes per instruction on issue 6169

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes were made, added code to ln 27 of file referenced.

Visuals before changes are applied

image

Visuals after changes are applied

image

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b aswutmaxcy-add-github-handle-6169 gh-pages
git pull https://github.com/aswutmaxcy/website.git add-github-handle-6169

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/aswutmaxcy/website/blob/add-github-handle-6169/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Mar 15, 2024
@colin-macrae colin-macrae self-requested a review March 15, 2024 17:46
@colin-macrae
Copy link
Member

colin-macrae commented Mar 15, 2024

Availability: 3/15, 18 (updated dates)
ETA: 3/18

@irais-valenzuela irais-valenzuela self-assigned this Mar 15, 2024
@irais-valenzuela
Copy link
Member

Review ETA: 4:15 PM 3/15/24
Availability: 3-4 PM Friday

Copy link
Member

@irais-valenzuela irais-valenzuela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aswutmaxcy, great job on the issue! You're branches are correct, there is a linked issue, and you successfully added the github handle variable for Kevin Phan. Awesome job!

Copy link
Member

@colin-macrae colin-macrae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aswutmaxcy, great job.

  • The branch is going into the correct branch gh-pages. ✅
  • The original issue [issue with #number] was properly referenced. ✅
  • Per the instructions on the original issue, the specified lines of code were properly updated. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Kevin Phan in civic-tech-index.md

4 participants