Skip to content

Added new variable github-handle to member Andrew Steman in ballot-navmd#6553

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
Maarimar:new-variable-ballot-nav.md-6237
Apr 5, 2024
Merged

Added new variable github-handle to member Andrew Steman in ballot-navmd#6553
jphamtv merged 1 commit intohackforla:gh-pagesfrom
Maarimar:new-variable-ballot-nav.md-6237

Conversation

@Maarimar
Copy link
Member

@Maarimar Maarimar commented Apr 1, 2024

Fixes #6237

What changes did you make?

  • Added new variable github-handle to member Andrew Steman in ballot-nav.md right bellow the name

Why did you make the changes (we will use this info to test)?

  • The one variable will replace two variables to reduce redundancy.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visible changes to the website.

@github-actions
Copy link

github-actions bot commented Apr 1, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Maarimar-new-variable-ballot-nav.md-6237 gh-pages
git pull https://github.com/Maarimar/website-HfLA.git new-variable-ballot-nav.md-6237

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Maarimar/website/blob/new-variable-ballot-nav.md-6237/CONTRIBUTING.md  

Copy link
Member

@aqandrew aqandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maarimar, thank you for making this PR! You implemented the requested change in the correct file/branch, taking care to indent with spaces instead of tabs. I can confirm locally that your change doesn't affect the appearance of /projects/ballot-nav.

However, this PR closes issue #6237, correct? In keeping with our regular workflow, I think these changes need to be made:

  • The first line of your original PR comment should be Fixes #6237, not Fixes #6553.
  • You closed #6237 manually 2 days ago. Please reopen that issue. Once this PR is merged, the issue will be closed automatically, and we'll have a record that this PR is what closed it.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 3, 2024
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

  • The branches are correct and the issue is linked.
  • The correct file was changed with the correct information.
  • I have inspected and confirmed there are no changes in developer mode on Chrome (desktop, tablet, and mobile view), Firefox, and Safari browser.

Please note the edit made to your responses and use as an example going forward with future issues.

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Maarimar - thanks for your contribution and for addressing the excellent feedback from @aqandrew and @heejung-hong. PR approved.

For future issues, after making requested changes, click the circular arrows icon next to the reviewer's name to request a new review. Thanks!

Screenshot 2024-04-04 at 21 34 19

@jphamtv jphamtv dismissed aqandrew’s stale review April 5, 2024 04:40

Confirmed the changes requested were completed

@jphamtv jphamtv merged commit dcf635f into hackforla:gh-pages Apr 5, 2024
freaky4wrld pushed a commit to freaky4wrld/website that referenced this pull request Apr 9, 2024
…vmd (hackforla#6553)

Co-authored-by: Mariana Osorio Lozano <marianaosoriolozano@Marianas-MacBook-Air.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Andrew Steman in ballot-nav.md

4 participants