Added new variable github-handle to member Andrew Steman in ballot-navmd#6553
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL: |
aqandrew
left a comment
There was a problem hiding this comment.
Hi @Maarimar, thank you for making this PR! You implemented the requested change in the correct file/branch, taking care to indent with spaces instead of tabs. I can confirm locally that your change doesn't affect the appearance of /projects/ballot-nav.
However, this PR closes issue #6237, correct? In keeping with our regular workflow, I think these changes need to be made:
- The first line of your original PR comment should be
Fixes #6237, notFixes #6553. - You closed #6237 manually 2 days ago. Please reopen that issue. Once this PR is merged, the issue will be closed automatically, and we'll have a record that this PR is what closed it.
There was a problem hiding this comment.
Good work!
- The branches are correct and the issue is linked.
- The correct file was changed with the correct information.
- I have inspected and confirmed there are no changes in developer mode on Chrome (desktop, tablet, and mobile view), Firefox, and Safari browser.
Please note the edit made to your responses and use as an example going forward with future issues.
There was a problem hiding this comment.
Hi @Maarimar - thanks for your contribution and for addressing the excellent feedback from @aqandrew and @heejung-hong. PR approved.
For future issues, after making requested changes, click the circular arrows icon next to the reviewer's name to request a new review. Thanks!
Confirmed the changes requested were completed
…vmd (hackforla#6553) Co-authored-by: Mariana Osorio Lozano <marianaosoriolozano@Marianas-MacBook-Air.local>
Fixes #6237
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visible changes to the website.