Skip to content

Added GitHub handle for Chali Prasertsri#6616

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
danajeon:add-github-handle-6172
Apr 12, 2024
Merged

Added GitHub handle for Chali Prasertsri#6616
jphamtv merged 1 commit intohackforla:gh-pagesfrom
danajeon:add-github-handle-6172

Conversation

@danajeon
Copy link
Member

@danajeon danajeon commented Apr 10, 2024

Fixes #6172

What changes did you make?

  • Added github-handle variable for Chali Prasertsri.

Why did you make the changes (we will use this info to test)?

  • To reduce redundancy in project file, a single variable is created to replace two variables.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Modified civic-tech-index.md file. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b danajeon-add-github-handle-6172 gh-pages
git pull https://github.com/danajeon/website.git add-github-handle-6172

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/danajeon/website/blob/add-github-handle-6172/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 10, 2024
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @danajeon,

Your comment section is not complete.
Please answer "Why did you make the changes (we will use this info to test)?"
The Screenshot section of the comment also needs to be corrected if there are no visual changes per the instructions here.

Once the corrections are made, I will approve your pull request.

Thank you

Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

  • The branches are correct and the issue is linked.
  • The correct file was changed with the correct information.
  • I have inspected and confirmed there are no visible changes in developer mode on Chrome (desktop, tablet, and mobile view), Firefox, and Safari browser.

Nice effort on revising the comment section. Please review my edits and refer to it going forward in answering questions one and two. Thank you

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @danajeon - Thanks for working on this issue!

Your code change correctly uses spaces instead of tabs.

Great job!

@jphamtv jphamtv merged commit dfbffef into hackforla:gh-pages Apr 12, 2024
@danajeon danajeon deleted the add-github-handle-6172 branch April 12, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Chali Prasertsri in civic-tech-index.md

3 participants