Skip to content

Add GitHub-handle for Nandana Rao - #6174#6629

Merged
W1LD-R merged 10 commits intohackforla:gh-pagesfrom
Kle012:add-github-handle-6174
Apr 12, 2024
Merged

Add GitHub-handle for Nandana Rao - #6174#6629
W1LD-R merged 10 commits intohackforla:gh-pagesfrom
Kle012:add-github-handle-6174

Conversation

@Kle012
Copy link
Member

@Kle012 Kle012 commented Apr 12, 2024

Fixes #6174

What changes did you make?

  • Add github-handle for Nandana Rao

Why did you make the changes (we will use this info to test)?

  • To reduce redundancy, a single variable is created to replace two variables.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Kle012-add-github-handle-6174 gh-pages
git pull https://github.com/Kle012/website.git add-github-handle-6174

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Kle012/website/blob/add-github-handle-6174/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 12, 2024
Copy link
Member

@heejung-hong heejung-hong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work!

  • The branches are correct and the issue is linked.
  • The correct file was changed with the correct information.
  • I have inspected and confirmed there are no visible changes in developer mode on Chrome (desktop, tablet, and mobile view), Firefox, and Safari browser.

Please note the edit of the answer to the second question and refer to this format going forward. Thank you

@robertnjenga robertnjenga self-requested a review April 12, 2024 19:45
@robertnjenga
Copy link
Member

Review ETA: 04/12/2024
Availability: 11am - 2pm

Copy link
Member

@robertnjenga robertnjenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kle012! Great job with this issue.
The basics are good, the branching was done correctly, you linked the issue, gave a description of what you did and why the changes were made, i.e adding the github-handle.
I'm able to confirm in Docker that there are no behavior or appearance changes on the page. Thank you for taking up the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Nandana Rao in civic-tech-index.md

4 participants