Skip to content

Added github handle for Evan Stalker in _projects brigade-organizers-playbook.md 6155#6635

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
duojet2ez:add-github-handle-Evan-Stalker-brigade-organizers-playbook-6155
Apr 15, 2024
Merged

Added github handle for Evan Stalker in _projects brigade-organizers-playbook.md 6155#6635
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
duojet2ez:add-github-handle-Evan-Stalker-brigade-organizers-playbook-6155

Conversation

@duojet2ez
Copy link
Member

@duojet2ez duojet2ez commented Apr 13, 2024

Fixes #6155

What changes did you make?

I went into _projects/brigade-organizers-playbook.md and added a variable 'github-handle:' under the name Evan Stalker

Why did you make the changes (we will use this info to test)?

Because eventually github-handle will replace github and picture variables to reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b duojet2ez-add-github-handle-Evan-Stalker-brigade-organizers-playbook-6155 gh-pages
git pull https://github.com/duojet2ez/website.git add-github-handle-Evan-Stalker-brigade-organizers-playbook-6155

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/duojet2ez/website/blob/add-github-handle-Evan-Stalker-brigade-organizers-playbook-6155/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 13, 2024
@tony1ee tony1ee self-requested a review April 13, 2024 20:02
@tony1ee
Copy link
Member

tony1ee commented Apr 13, 2024

Review ETA: EOD 04/13/2024
Availability: 12-8 PM SAT

Copy link
Member

@tony1ee tony1ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done @duojet2ez!

Here's what you did great:

  • chose the correct branch for the pull request
  • correctly linked the issue
  • made the correct changes to the correct file
  • no visual changes in the browser (verified on Chrome with Desktop, Tablet and Mobile view, Safari and Firefox)
  • source code changes appeared applicable and clean

Note that I made an edit to your comment for clearer description of the file changed.

@gaylem gaylem requested a review from JackCasica April 14, 2024 17:19
@JackCasica
Copy link
Member

HI @duojet2ez ~

In this PR you...

image

PR Approved!

@t-will-gillis t-will-gillis merged commit 0ddb547 into hackforla:gh-pages Apr 15, 2024
aidanwsimmons pushed a commit to aidanwsimmons/website that referenced this pull request Apr 17, 2024
@duojet2ez duojet2ez deleted the add-github-handle-Evan-Stalker-brigade-organizers-playbook-6155 branch September 12, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Evan Stalker in brigade-organizers-playbook.md

4 participants