Skip to content

Added github handle for Sean Sada#6647

Merged
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
moazDev1:add-github-handle-6170
Apr 15, 2024
Merged

Added github handle for Sean Sada#6647
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
moazDev1:add-github-handle-6170

Conversation

@moazDev1
Copy link
Member

Fixes #6170

What changes did you make?

  • Added github handle for Sean Sada

Why did you make the changes (we will use this info to test)?

  • To add github handle for Sean Sada in _projects/civic-tech-index.md

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Changed the _projects/civic-tech-index.md file to add github-handle variable

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b moaz-dev1-add-github-handle-6170 gh-pages
git pull https://github.com/moaz-dev1/website.git add-github-handle-6170

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/moaz-dev1/website/blob/add-github-handle-6170/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 15, 2024
@tony1ee tony1ee self-requested a review April 15, 2024 01:10
@tony1ee
Copy link
Member

tony1ee commented Apr 15, 2024

Review ETA: EOD 04/14/2024
Availability: 6-9 PM 04/14/2024

Copy link
Member

@tony1ee tony1ee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @moaz-dev1 on:

  1. Using the correct branch for your pull request.
  2. Accurately linking the issue.
  3. Making code changes as requested in the issue
  4. Ensuring no visual changes across multiple browsers (Safari, Firefox, Chrome) in both desktop and mobile views.
  5. Applicable and clean code changes.

Note that an edit was made to your comment for a clearer description in the Why did you make the changes section

@moazDev1 moazDev1 closed this Apr 15, 2024
@moazDev1 moazDev1 deleted the add-github-handle-6170 branch April 15, 2024 06:15
@moazDev1 moazDev1 restored the add-github-handle-6170 branch April 15, 2024 06:16
@moazDev1 moazDev1 reopened this Apr 15, 2024
@moazDev1 moazDev1 closed this Apr 15, 2024
@moazDev1 moazDev1 deleted the add-github-handle-6170 branch April 15, 2024 06:17
@moazDev1 moazDev1 restored the add-github-handle-6170 branch April 15, 2024 06:24
@moazDev1 moazDev1 reopened this Apr 15, 2024
@freaky4wrld freaky4wrld self-requested a review April 15, 2024 09:26
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moaz-dev1 thanks for taking up the issue

  • branches looks good
  • linked issue is correct
  • local testing shows desired results

PR approved !!

@freaky4wrld freaky4wrld merged commit 5c65f7b into hackforla:gh-pages Apr 15, 2024
Cloid pushed a commit to Cloid/hackforla_website that referenced this pull request Apr 15, 2024
Co-authored-by: Moaz Ali <moaaz98@users.noreply.github.com>
aidanwsimmons pushed a commit to aidanwsimmons/website that referenced this pull request Apr 17, 2024
Co-authored-by: Moaz Ali <moaaz98@users.noreply.github.com>
@moazDev1 moazDev1 deleted the add-github-handle-6170 branch April 20, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Sean Sada in civic-tech-index.md

3 participants