Skip to content

Add github-handle for Melinda Sukosd#6678

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
Kle012:add-github-handle-5880
Apr 25, 2024
Merged

Add github-handle for Melinda Sukosd#6678
jphamtv merged 1 commit intohackforla:gh-pagesfrom
Kle012:add-github-handle-5880

Conversation

@Kle012
Copy link
Member

@Kle012 Kle012 commented Apr 18, 2024

Fixes #5880

What changes did you make?

  • Add github-handle under Melinda Sukosd

Why did you make the changes (we will use this info to test)?

  • Good first issue
  • To reduce redundancy in the project file

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b Kle012-add-github-handle-5880 gh-pages
git pull https://github.com/Kle012/website.git add-github-handle-5880

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/Kle012/website/blob/add-github-handle-5880/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 18, 2024
@Chrisklangley Chrisklangley self-requested a review April 18, 2024 00:59
@Chrisklangley
Copy link
Contributor

availability: M-F 6:30pm -9pm
ETA 04/19/24

@A-Wu5 A-Wu5 self-requested a review April 18, 2024 01:07
@A-Wu5
Copy link
Member

A-Wu5 commented Apr 18, 2024

Availability: 4/17/24 6-7PM
ETA: End of day

@A-Wu5
Copy link
Member

A-Wu5 commented Apr 18, 2024

Hello @Kle012! Great job on your first issue. The changes requested on #5880 have been done correctly. However, in the "Why did you make the changes" section of this pull request description please describe why this change was necessary in regards to the overall website. For instance, you can put something like "To reduce redundancy in the project file" to make that section more clear.

Copy link
Member

@A-Wu5 A-Wu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to above comment

@Thinking-Panda
Copy link
Member

@Chrisklangley - Please review the PR whenever possible.

@Kle012
Copy link
Member Author

Kle012 commented Apr 24, 2024

Hi @A-Wu5, thank you for reviewing. I just updated the "Why did you make the changes" section.

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Kle012,

  • The pull request is done with the correct branch
  • The issue is properly linked
  • Your summary of changes is clear
  • Your code change correctly uses spaces instead of tabs to indent

Thanks for your contribution to this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Melinda Sukosd in civic-tech-jobs.md

5 participants