Skip to content

Added New Variable Github-Handle for Ray Fambro#6682

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:add-github-handle-6191
Apr 21, 2024
Merged

Added New Variable Github-Handle for Ray Fambro#6682
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:add-github-handle-6191

Conversation

@jenjenkayi
Copy link
Member

Fixes #6191

What changes did you make?

  • Added new variable github-handle for Ray Fambro in civic-opportunity-project.md.

Why did you make the changes (we will use this info to test)?

  • Reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

Adding a new variable to a file. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!

From your project repository, check out a new branch and test the changes.

git checkout -b jenjenkayi-add-github-handle-6191 gh-pages
git pull https://github.com/jenjenkayi/website.git add-github-handle-6191

Note that CONTRIBUTING.md cannot previewed locally; rather it should be previewed at this URL:

https://github.com/jenjenkayi/website/blob/add-github-handle-6191/CONTRIBUTING.md  

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 18, 2024
Copy link
Member

@partapparam partapparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jenjenkayi good job!

  • Choosing the correct branch for pull request
  • Linking the issue
  • Creating a single variable "github-handle"
  • Using spaces instead of a tab to indent
  • Making no changes to the project webpage appearance

@t-will-gillis t-will-gillis self-requested a review April 21, 2024 16:55
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jenjenkayi Great job- branches from and to are good, original issue is linked, there is a concise explanation for what was done and why, no visual changes are noted, and the code edit is clean. The Civic Opportunity Project appears correct on Docker.

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add new variable github-handle to member Ray Fambro in civic-opportunity-project.md

3 participants