Skip to content

651 getting started bug#673

Merged
efrenmarin45 merged 9 commits intohackforla:gh-pagesfrom
efrenmarin45:651-gettingStarted-bug
Aug 18, 2020
Merged

651 getting started bug#673
efrenmarin45 merged 9 commits intohackforla:gh-pagesfrom
efrenmarin45:651-gettingStarted-bug

Conversation

@efrenmarin45
Copy link
Member

Fixes #651

@efrenmarin45 efrenmarin45 self-assigned this Aug 6, 2020
@efrenmarin45 efrenmarin45 added the Bug Something isn't working label Aug 6, 2020
@efrenmarin45 efrenmarin45 requested review from a user, KianBadie, ruben1s and ye-susan August 6, 2020 23:24
@KianBadie
Copy link
Member

It looks like there are some fragments of code that were left behind by a merge in the _footer and 2FA scss files. I think it would be a good idea to remove those.

The margins you added does indeed move the Getting Started header section to a spot that's easier on the eyes, so nice job. I want to point out the new margins reveal a grey bar above the getting started header section, and it also looks like a slightly different size grey bar is bellow the getting started header section. It looks like this is from the background color of the #app id css rules. I think it would be a good idea to cover those up some how. Maybe by some how extending the header section to cover those gap areas (if they are even gap areas, I'm not entirely sure what's making them do that)?

Would you have the time to add these changes? And also last thing I would recommend is squashing the commit messages into one message just so we can keep the commit logs a bit cleaner. I think usually it's not the biggest deal if it a couple extra commit messages, but I think the commits like "Merge pull request #1 from hackforla/gh-pages" qualifies the commit messages to be merged into one. Feel free to message me on slack if you make a new pull request and I'll hop on it to review asap.

ruben1s
ruben1s approved these changes Aug 9, 2020
@efrenmarin45
Copy link
Member Author

efrenmarin45 commented Aug 16, 2020

@KianBadie Fixed grey bar issue. Appears it was just a simple styling issue with padding and margins. Uploaded image to issue for reference. I removed the commented out code on the Footer and 2FA Sass files to clean up the code. Unable to squash all commits into one on my end. Will be reaching out to you on Slack to get more assistance on this for future commits.

@efrenmarin45 efrenmarin45 merged commit 09408fc into hackforla:gh-pages Aug 18, 2020
efrenmarin45 added a commit that referenced this pull request Aug 18, 2020
@efrenmarin45 efrenmarin45 deleted the 651-gettingStarted-bug branch August 30, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Getting Started Page Accordion and Whitespace

3 participants