Skip to content

Title Added Github-handle for Faezeh Faezipour#6776

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
del9ra:add-github-handle-for-faezeh-faezipour-6704
Apr 30, 2024
Merged

Title Added Github-handle for Faezeh Faezipour#6776
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
del9ra:add-github-handle-for-faezeh-faezipour-6704

Conversation

@del9ra
Copy link
Member

@del9ra del9ra commented Apr 29, 2024

Fixes #6704

What changes did you make?

-Replaced "- name: Faezeh Faezipour" with "- name: Faezeh Faezipour
github-handle:"

Why did you make the changes (we will use this info to test)?

  • To be able to hold the github handle for each member of the leadership team
  • To avoid redundancy by replacing two variables

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Apr 29, 2024
@roslynwythe
Copy link
Member

@del9ra I believe we have resolved the problem causing the failed "Add Pull Request Instructions" check. I would like to close this PR and have you create a new one with the same branch. Would you be willing to do that?

Copy link
Member

@taylorbeee taylorbeee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @del9ra thanks for taking up the issue, branch looks good, the issue is linked correctly and spaces were used rather than tabs. Testing on local machine shows desired result. Great job.

Approved!

EDIT** I see this issue is getting re-created to work around "Add Pull Request Instructions" problem. Disregard

@Thinking-Panda Thinking-Panda requested review from Thinking-Panda and removed request for Thinking-Panda April 29, 2024 21:19
Copy link
Member

@roslynwythe roslynwythe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @del9ra for work on this issue

  • The branches are setup correctly and you have described your work
  • The code change is clean and correct
  • It checks out in the browser

Please disregard the error message regarding the failed GitHub check. Great job!

@roslynwythe
Copy link
Member

roslynwythe commented Apr 30, 2024

@taylorbeee This PR did not have to be re-created after all. Part of the reason I thought we should re-create it is so reviewers would have the benefit of the instructions for pulling down the branch, but it appears that you had no problem with that.
Thank you for your review and I apologize for the confusion.

@roslynwythe roslynwythe merged commit 1648e22 into hackforla:gh-pages Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Faezeh Faezipour in design-systems.md

3 participants