Title Added Github-handle for Faezeh Faezipour#6776
Conversation
|
@del9ra I believe we have resolved the problem causing the failed "Add Pull Request Instructions" check. I would like to close this PR and have you create a new one with the same branch. Would you be willing to do that? |
There was a problem hiding this comment.
Hey @del9ra thanks for taking up the issue, branch looks good, the issue is linked correctly and spaces were used rather than tabs. Testing on local machine shows desired result. Great job.
Approved!
EDIT** I see this issue is getting re-created to work around "Add Pull Request Instructions" problem. Disregard
roslynwythe
left a comment
There was a problem hiding this comment.
Thank you @del9ra for work on this issue
- The branches are setup correctly and you have described your work
- The code change is clean and correct
- It checks out in the browser
Please disregard the error message regarding the failed GitHub check. Great job!
|
@taylorbeee This PR did not have to be re-created after all. Part of the reason I thought we should re-create it is so reviewers would have the benefit of the instructions for pulling down the branch, but it appears that you had no problem with that. |
Fixes #6704
What changes did you make?
-Replaced "- name: Faezeh Faezipour" with "- name: Faezeh Faezipour
github-handle:"
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.