Skip to content

Added Github-handle for Rachel Newcomb#6808

Merged
W1LD-R merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:add-github-handle-6705
May 3, 2024
Merged

Added Github-handle for Rachel Newcomb#6808
W1LD-R merged 1 commit intohackforla:gh-pagesfrom
jenjenkayi:add-github-handle-6705

Conversation

@jenjenkayi
Copy link
Member

Fixes #6705

What changes did you make?

  • Added github-handle for Rachel Newcomb in design-systems.md.

Why did you make the changes (we will use this info to test)?

  • Reducing redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • Adding github-handle to the file. No visual changes to the website.

@github-actions
Copy link

github-actions bot commented May 2, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jenjenkayi-add-github-handle-6705 gh-pages
git pull https://github.com/jenjenkayi/website.git add-github-handle-6705

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 2, 2024
@moazDev1 moazDev1 self-requested a review May 3, 2024 10:20
@moazDev1
Copy link
Member

moazDev1 commented May 3, 2024

Availability: 5/3 6PM - 9PM
ETA: EOD 5/3

Copy link
Member

@moazDev1 moazDev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jenjenkayi, Great job on:

  1. Using the correct branch for your pull request.
  2. Accurately linking the issue.
  3. Making code changes as requested in the issue
  4. Ensuring no visual changes across multiple browsers (Safari, Firefox, Chrome) in both desktop and mobile views.
  5. Applicable and clean code changes.

Keep going!!

@DeniseLewis1 DeniseLewis1 self-requested a review May 3, 2024 17:59
@DeniseLewis1
Copy link
Member

Availability: 5/3 11AM - 3PM
Review ETA: End of day 5/3

Copy link
Member

@DeniseLewis1 DeniseLewis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @jenjenkayi great work!

  • Used correct branch for pull request
  • Correctly linked the issue
  • Used spaces instead of tab in the right file
  • Confirmed no visual changes across Firefox and Chrome in desktop, mobile, and tablet views

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Rachel Newcomb in design-systems.md

4 participants