Skip to content

added gh handle for wataru inoue#6814

Merged
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
smendoza07:add-gh-handle-for-wataru-inoue-#6703
May 7, 2024
Merged

added gh handle for wataru inoue#6814
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
smendoza07:add-gh-handle-for-wataru-inoue-#6703

Conversation

@smendoza07
Copy link
Member

@smendoza07 smendoza07 commented May 4, 2024

Fixes #6703

What changes did you make?

  • Added "github-handle" for Wataru Inoue

Why did you make the changes (we will use this info to test)?

  • To hold the github handle for each member of the leadership team

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes

@github-actions
Copy link

github-actions bot commented May 4, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b smendoza07-add-gh-handle-for-wataru-inoue-#6703 gh-pages
git pull https://github.com/smendoza07/website.git add-gh-handle-for-wataru-inoue-#6703

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 4, 2024
@partapparam partapparam self-requested a review May 4, 2024 01:16
Copy link
Member

@partapparam partapparam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smendoza07 good work!

  • The PR is done with the correct branch
  • The issue is properly linked
  • The changes were done correctly
  • No visual changes were made to the website

@urvishp13 urvishp13 self-requested a review May 7, 2024 16:51
@urvishp13
Copy link
Member

Review ETA: 1-4pm 5/7/24
Availability: 1-4pm 5/7/24

Copy link
Member

@urvishp13 urvishp13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @smendoza07 in completing this issue!

  • pull request is done with the correct branch
  • the issue is successfully linked
  • good job making sure to use spaces rather than tab when writing github-handle
  • there are indeed no changes in the website's appearance in desktop, tablet, and mobile views (tested in Firefox and Chrome)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github-handle for Wataru Inoue in design-systems.md

4 participants