Updating github handle for Bonnie W#6821
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
|
ETA: 05/06/24 |
Chrisklangley
left a comment
Chrisklangley
left a comment
There was a problem hiding this comment.
Hey @nssensalo
Great work on your Pull request !
you linked your issue and made clear documentation of the changes you made on line 14 of _projects/civic-tech-structure.md file
Great work!
|
ETA: 5/9/24 |
pdimaano
left a comment
pdimaano
left a comment
There was a problem hiding this comment.
@nssensalo Thank you for creating this pull request, I just have a few suggestions for changes to be made before final approval:
For the linked issue, make sure you select the appropriate checkboxes that you have completed prior to creating the pull request. This makes it easier for you and the reviewers to keep track of what steps have already been completed.
The linked issue also states that the webpage appearance should be unchanged after updating the code. According to the Hack for LA website contributing documentation, you do not need to include screenshots if this is the case. You can remove the pre-placed text in the "Screenshots" section and write a statement like "No visual changes to the website."
Please make the appropriate changes and I will continue the review process, thanks!
|
Phillip,
Thank you for verifying the webpage would be unchanged after my updates. I
could not find that information but I'm going to go back and try to track
it down for future issues.
And yes, I forgot to check those boxes this time around, will be sure to
stick to my cheat sheet until the process is memorized/more second nature.
Thanks,
Nansamba
…On Mon, May 6, 2024 at 10:13 PM Philip Dimaano ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@nssensalo <https://github.com/nssensalo> Thank you for creating this
pull request, I just have a few suggestions for changes to be made before
final approval:
For the linked issue, make sure you select the appropriate checkboxes that
you have completed prior to creating the pull request. This makes it easier
for you and the reviewers to keep track of what steps have already been
completed.
The linked issue also states that the webpage appearance should be
unchanged after updating the code. According to the Hack for LA website
contributing documentation, you do not need to include screenshots if this
is the case. You can remove the pre-placed text in the "Screenshots"
section and write a statement like "No visual changes to the website."
Please make the appropriate changes and I will continue the review
process, thanks!
—
Reply to this email directly, view it on GitHub
<#6821 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUNBSNYYYCD3KMOYHCSHBQ3ZBBPG3AVCNFSM6AAAAABHIFPFKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBSGA3TKOJRGQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Review ETA: EST 11 PM 5/7/24 |
del9ra
left a comment
del9ra
left a comment
There was a problem hiding this comment.
HI @nssensalo,
- the pull request is done with the correct branch
- the Issue is linked properly
- since no changes were implemented, you can omit screenshots. You are not supposed to see any changes
- the checkboxes in the issue were not marked off
Nice job overall! Please make the necessary changes to the code and I will approve your PR.
|
Hi @del9ra,
I've checked off the boxes and removed the images.
Let me know if there are any issues. It's now in the pull request "changes
requested" mode.
Thanks,
Nansamba
…On Tue, May 7, 2024 at 6:47 PM Delgira Dordzhieva ***@***.***> wrote:
***@***.**** requested changes on this pull request.
HI @nssensalo <https://github.com/nssensalo>,
- the pull request is done with the correct branch
- the Issue is linked properly
- since no changes were implemented, you can omit screenshots. You are
not supposed to see any changes
- the checkboxes in the issue were not marked off
Nice job overall! Please make the necessary changes to the code and I
will approve your PR.
—
Reply to this email directly, view it on GitHub
<#6821 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AUNBSN6NPZDSAB26Z75VAHLZBF72JAVCNFSM6AAAAABHIFPFKKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDANBUGQ3TIMJZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
pdimaano
left a comment
pdimaano
left a comment
There was a problem hiding this comment.
@nssensalo Thank you for making the requested changes. The branches are correct and the issue is linked. The webpage appearance is unchanged on my system on desktop, mobile and tablet. The correct file was updated with the requested information. Well done!
5 participants
Fixes #6759
What changes did you make?
-Added github handle variable below name
Why did you make the changes (we will use this info to test)?
The greater plan is to replace name and github link with a variable.
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website.