Updating github handle for Eli Selkin in engage.md#6900
Updating github handle for Eli Selkin in engage.md#6900gaylem merged 2 commits intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
There was a problem hiding this comment.
Edit since I found the template for PR review and reviewing accordingly.
What works:
- branching was done correctly
- the issue number was listed
- code edit looks correct and only necessary code is added
- what and why in PR description are well-stated
To review:
- PR title is not descriptive. I would describe what you changed rather than listing the issue being fixed
- Good work on listing "No visual changes to website." under "Visuals before/after changes are applied", but the collapsible bullet points could be removed as well, leaving just "No visual changes to website." under "Screenshots of Proposed Changes..."
Overall great work! Thank you for contributing.
found potential issue that needed to be review
|
Hi @del9ra! Thanks for volunteering to review this issue! When you have a minute, please add your ETA and Availability. |
|
Review ETA: 10 PM 5/30/24 |
There was a problem hiding this comment.
Hey @vanessasinam,
- The branching looks good.
- The issue is linked properly.
- I would make the title more descriptive
- Your explanation of the changes is clear.
- The project's webpage looks the same.
Nice work, and thanks for contributing to the website!
|
Hey @vanessasinam, @muninnhugin provided feedback that needs to be addressed. Please make those changes and re-request a review from them by clicking on the circular arrows icon next to their name. Thanks! |
|
@vanessasinam I previously reviewed this PR and edited it according to my understanding of how it should look: #6900 (review). |
I've just made the changes! |
ha-bach
left a comment
There was a problem hiding this comment.
The PR title is descriptive and the visual changes description is clean!
Thank you for adding the changes, and for contributing!!

Fixes #6731
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to website.