Updated alt text for Sitemap Header Hero image#6958
Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom Jun 6, 2024
Merged
Updated alt text for Sitemap Header Hero image#6958jphamtv merged 1 commit intohackforla:gh-pagesfrom
jphamtv merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
Member
|
Review ETA: 11:59 PM PST, 6/4/24 |
terrencejihoonjung
suggested changes
Jun 5, 2024
Member
terrencejihoonjung
left a comment
terrencejihoonjung
left a comment
There was a problem hiding this comment.
- branching is correct, issue is listed
alt=""is correctly replacing the previous value- PR title is clear and concise
- changes made and why they were made are clearly stated
Changes Requested:
- note whether there were visual changes in the PR
Once you've completed these changes, you are good to go! Thank you and good job!
terrencejihoonjung
approved these changes
Jun 5, 2024
Member
terrencejihoonjung
left a comment
terrencejihoonjung
left a comment
There was a problem hiding this comment.
Changes look good! Thanks @andyphancode!
Member
|
Review ETA: 6/5 EOD |
Member
|
ETA: EoD |
ino-iosdev
approved these changes
Jun 5, 2024
Member
ino-iosdev
left a comment
ino-iosdev
left a comment
There was a problem hiding this comment.
Hi @andyphancode , It's such a blessing to have you as part of the team here!
- Naming was appropriate
- Direction between branches
fromandtoare clear - The changes to
alt=""and why were clear - PR issue link was clear
- No visual changes to the website
Great job, thank you for contributing!
ino-iosdev
approved these changes
Jun 5, 2024
jchue
approved these changes
Jun 6, 2024
Member
jchue
left a comment
jchue
left a comment
There was a problem hiding this comment.
I don't think you need my approval anymore, but nice job, @andyphancode.
- Pull request done with correct branch
- Correct issue linked
altproperty correctly updated- Site Map webpage unchanged
This was referenced Aug 10, 2025
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6798
What changes did you make?
Why did you make the changes (we will use this info to test)?
Visual Changes