PR Added github-handle for Sarah Edwards in projects file#7130
PR Added github-handle for Sarah Edwards in projects file#7130t-will-gillis merged 4 commits intohackforla:gh-pagesfrom elsong86:feature
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Hi @elsong86, thanks for taking this up! Changes look good:
Just a couple of suggestions:
After that everything should be good! |
|
I have now updated my comment with the requested changes. Thank you. |
|
Hi @cchrizzle! Thank you for reviewing and your feedback on this PR. Please review the updates @elsong86 made and use the |
cchrizzle
left a comment
There was a problem hiding this comment.
Thanks for making the requested changes!
Please also specify "Sarah Edwards" in the "What changes did you make?" section of your pull request and it will be good to go.
|
@LRenDO Got it, thank you! |
|
Added Sarah Edwards to changes made section. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @elsong86 - great job on this issue. The PR is linked to the original issue, there are concise descriptions of what was done and why, there is a note for no visual changes, and the code edits are clean. Thanks for coordinating with @cchrizzle on the edits. For the next issue, please remember to use a short, descriptive name and include the issue number when you create the branch you will be working on.
Thanks for working on this!
Fixes #7103
This PR adds the github-handle variable for each member of the leadership team in the guides-team file, addressing issue #7103.
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)