Skip to content

PR Added github-handle for Sarah Edwards in projects file#7130

Merged
t-will-gillis merged 4 commits intohackforla:gh-pagesfrom
elsong86:feature
Jul 26, 2024
Merged

PR Added github-handle for Sarah Edwards in projects file#7130
t-will-gillis merged 4 commits intohackforla:gh-pagesfrom
elsong86:feature

Conversation

@elsong86
Copy link
Member

@elsong86 elsong86 commented Jul 19, 2024

Fixes #7103

This PR adds the github-handle variable for each member of the leadership team in the guides-team file, addressing issue #7103.

What changes did you make?

  • Added github-handle variable for leadership team member Sarah Edwards.

Why did you make the changes (we will use this info to test)?

  • To reduce redundancy in project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

  • No visual changes.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b elsong86-feature gh-pages
git pull https://github.com/elsong86/website.git feature

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jul 19, 2024
@elsong86 elsong86 changed the title Feature PR Added github-handle in projects file Jul 19, 2024
@elsong86 elsong86 self-assigned this Jul 22, 2024
@cchrizzle cchrizzle self-requested a review July 22, 2024 21:20
@cchrizzle
Copy link
Member

Hi @elsong86, thanks for taking this up!

Changes look good:

  1. Linked to the original issue correctly
  2. Added the correct section name of "github-handle"
  3. Used spaces for the indentation instead of a tab like the instructions directed

Just a couple of suggestions:

  1. Check off the checkboxes in the issue link to show your progress and completion.
  2. Specify who you added the section to (Sarah Edwards in this case).
  3. Remove the empty bullet points after "To reduce redundancy in project file".
  4. Remove what is currently under the screenshots section since there are no visual changes to the website from the changes and specify that there were no visual changes to the website from your update.

After that everything should be good!

@elsong86 elsong86 changed the title PR Added github-handle in projects file PR Added github-handle for Sarah Edwards in projects file Jul 23, 2024
@elsong86
Copy link
Member Author

I have now updated my comment with the requested changes. Thank you.

@LRenDO
Copy link
Member

LRenDO commented Jul 24, 2024

Hi @cchrizzle! Thank you for reviewing and your feedback on this PR. Please review the updates @elsong86 made and use the Review Changes button on the Files Changed tab. You can select Approve or Request Changes in that comment box based on what you would like to do. Thanks!

Copy link
Member

@cchrizzle cchrizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes!

Please also specify "Sarah Edwards" in the "What changes did you make?" section of your pull request and it will be good to go.

@cchrizzle
Copy link
Member

@LRenDO Got it, thank you!

@elsong86 elsong86 requested a review from cchrizzle July 24, 2024 22:21
@elsong86
Copy link
Member Author

Added Sarah Edwards to changes made section.

Copy link
Member

@cchrizzle cchrizzle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, approved!

@t-will-gillis t-will-gillis self-requested a review July 26, 2024 04:27
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @elsong86 - great job on this issue. The PR is linked to the original issue, there are concise descriptions of what was done and why, there is a note for no visual changes, and the code edits are clean. Thanks for coordinating with @cchrizzle on the edits. For the next issue, please remember to use a short, descriptive name and include the issue number when you create the branch you will be working on.

Thanks for working on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Sarah Edwards in guides-team.md

4 participants