Remove Bourbon SASS framework#720
Merged
ExperimentsInHonesty merged 3 commits intohackforla:gh-pagesfrom Sep 11, 2020
Merged
Conversation
…ile clicking around to test your dev site.
We were using very little of the Bourbon framework. Removed it and then removed or replaced the few mixins we were using with their Bootstrap equivalents. When we add in Bootstrap, we will probably want to remove _sass/core/_mixins.scss and _sass/variables/_utilities.scss
Member
Author
|
I think this automated page comparison should be visible to everyone. https://percy.io/cd0fd004/Hack-for-LA-Website/builds/6781468 |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were using relatively little of Bourbon. Removed it and added the few mixins we were using to _sass/core/_mixins.scss.
When we start using Bootstrap, we will probably want to delete those in favor of including the Bootstrap versions.
This is a step on the way to componentizing the website: issue #577