Skip to content

Add "github-handle" variable for Anousha Shadrach in tdm-calculator.md#7234

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
minkang3:add-github-handle-in-tdc-calc-7174
Aug 14, 2024
Merged

Add "github-handle" variable for Anousha Shadrach in tdm-calculator.md#7234
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
minkang3:add-github-handle-in-tdc-calc-7174

Conversation

@minkang3
Copy link
Member

@minkang3 minkang3 commented Aug 7, 2024

Fixes #7174

What changes did you make?

  • Added "github-handle" variable in the LA TDM Calculator project for the member Anousha Shardrach in tdm-calculator.md

Why did you make the changes (we will use this info to test)?

  • The variables were a bit verbose,github and picture variables were able to be condensed, reducing the redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes.

@github-actions
Copy link

github-actions bot commented Aug 7, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b minkang3-add-github-handle-in-tdc-calc-7174 gh-pages
git pull https://github.com/minkang3/website.git add-github-handle-in-tdc-calc-7174

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 7, 2024
@Anahisv23 Anahisv23 self-requested a review August 7, 2024 20:53
@Anahisv23
Copy link
Member

Availability: M - F 12pm - 5pm
ETA: EOD

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @minkang3, thanks for working on this ticket. Here's what you did well along with some feedback. Nice job!

What went well

  • Into and from branch are correct
  • There is a linked issue present
  • Modified the appropriate lines of code to add github-handle variable

Feedback

  • In your PR it would be helpful to be specific and descriptive about why you did the changes you did or mention what the goal of the ticket was.

@minkang3
Copy link
Member Author

minkang3 commented Aug 8, 2024

@Anahisv23 Thank you for the feedback, I'll keep that in mind for my next contribution.
I was wondering if there is anything left for me to do with the original issue #7174. Should I change the status to "Done" or will the automation take care of it? Thank you again. Also, should I close this pull request?

@Anahisv23
Copy link
Member

Hi @minkang3, could you please update this PR so its more specific and descriptive about why you did the changes you did or mention what the goal of the ticket was. The merge team will be the ones to close your PR. I think you should wait to update the status to done until the merge team has looked at your PR. Great questions!

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @minkang3, thanks for working on this issue! Your changes look good, there's just a couple small things to adjust.

Here's what looks good:

  • Your branches are set up correctly for merging.
  • You linked the original issue in the PR.
  • The code changes were made as described in the original issue.
  • When testing the changes locally, the page displays correctly with no visual changes.

To do:

  • As mentioned, the "Why did you make the changes" section should show that you understand the purpose of the changes you made. You can usually find this described in the original issue, in this case the new variable is going to replace two other variables in order to reduce redundancy in the project file, so your answer could be as simple as "To reduce redundancy in the file."
  • Since there are no visual changes to the website, you can delete both the details sections with screenshots and just put "No visual changes."

After you make the two changes, let me know in a comment or re-request a review and I'll come back and take another look!

Copy link
Member

@daras-cu daras-cu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @minkang3, everything looks good!

@roslynwythe roslynwythe merged commit 6fb39f5 into hackforla:gh-pages Aug 14, 2024
@minkang3 minkang3 deleted the add-github-handle-in-tdc-calc-7174 branch August 14, 2024 02:57
del9ra pushed a commit to del9ra/website that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Anousha Shadrach in tdm-calculator.md

4 participants