Skip to content

7078 post pbb migration refactor schedule friday workflow#7260

Merged
t-will-gillis merged 3 commits intohackforla:gh-pagesfrom
mrodz:7078-post-pbb-migration-refactor-schedule-friday-workflow
Aug 16, 2024
Merged

7078 post pbb migration refactor schedule friday workflow#7260
t-will-gillis merged 3 commits intohackforla:gh-pagesfrom
mrodz:7078-post-pbb-migration-refactor-schedule-friday-workflow

Conversation

@mrodz
Copy link
Member

@mrodz mrodz commented Aug 9, 2024

Fixes #7078

What changes did you make?

  • Inserts github-token from repository secrets at secrets.HACKFORLA_GRAPHQL_TOKEN to .github\workflows\schedule-fri-0700.yml here
  • Updated filtering of issues here following the issue's directions, and audited the fix for bugs
  • Updated fetch parameters to only include assigned users here
  • Added Dependency to the list of labels to exclude from the inactivity check here
  • Updated JSDoc here
    • I changed the return type details because it did not follow the JSDoc specification and also should have been Promise<Array> instead of Array
  • Capitalized "GitHub" here
  • Imported module used in this patch here

Why did you make the changes (we will use this info to test)?

  • Migrating to Project Boards (new) changed the API for how data for issues is laid out. We take advantage of the GraphQL API exposed through Octokit to ensure our CI/CD workflow can operate without hiccups.

Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)

No Visual Changes

Information for reviewers:

I replicated Hack4LA's project board in my own repo and created four issues to test some use cases:

A manual run of .github/workflows/schedule-fri-0700.yml gave the following output, only checking the age of mrodz#5, which is expected behavior.

Expand

@github-actions
Copy link

github-actions bot commented Aug 9, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b mrodz-7078-post-pbb-migration-refactor-schedule-friday-workflow gh-pages
git pull https://github.com/mrodz/hfla-website.git 7078-post-pbb-migration-refactor-schedule-friday-workflow

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large time sensitive Needs to be worked on by a particular timeframe Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 5pt Can be done in 19-30 hours Feature: API Coding requires using an API labels Aug 9, 2024
@t-will-gillis t-will-gillis self-requested a review August 10, 2024 03:12
@t-will-gillis
Copy link
Member

available: 8/10
eta: 8/10 eod

@t-will-gillis t-will-gillis requested a review from del9ra August 11, 2024 17:25
@t-will-gillis
Copy link
Member

Hey @mrodz apologies for the delay-

eta 8/12

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mrodz - fantastic work. Your branches are good, you are linked to the issue, the descriptions do a great job of explaining what you did and why, and you provided relevant links to your testing.

I changed the return type details because it did not follow the JSDoc specification and also should have been Promise<Array> instead of Array

Thank you for fixing this!

I ran this in my repo and the workflow appears to function as intended. Great job again and thank you for working on this.

@del9ra del9ra removed their request for review August 15, 2024 21:03
@t-will-gillis t-will-gillis merged commit c233f9b into hackforla:gh-pages Aug 16, 2024
del9ra pushed a commit to del9ra/website that referenced this pull request Aug 16, 2024
…7260)

* Refactor "Schedule Friday" workflow

* Remove import `statusFieldIds`

* fix improper JSDoc
@mrodz mrodz deleted the 7078-post-pbb-migration-refactor-schedule-friday-workflow branch October 1, 2024 23:54
@ExperimentsInHonesty ExperimentsInHonesty added the Lang: GHA GitHub Actions label Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Feature: API Coding requires using an API Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 5pt Can be done in 19-30 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Post PBB migration: Refactor "Schedule Friday" workflow

3 participants