7078 post pbb migration refactor schedule friday workflow#7260
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
available: 8/10 |
|
Hey @mrodz apologies for the delay- eta 8/12 |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @mrodz - fantastic work. Your branches are good, you are linked to the issue, the descriptions do a great job of explaining what you did and why, and you provided relevant links to your testing.
I changed the return type details because it did not follow the JSDoc specification and also should have been
Promise<Array>instead ofArray
Thank you for fixing this!
I ran this in my repo and the workflow appears to function as intended. Great job again and thank you for working on this.
…7260) * Refactor "Schedule Friday" workflow * Remove import `statusFieldIds` * fix improper JSDoc
Fixes #7078
What changes did you make?
github-tokenfrom repository secrets atsecrets.HACKFORLA_GRAPHQL_TOKENto.github\workflows\schedule-fri-0700.ymlhereDependencyto the list of labels to exclude from the inactivity check herePromise<Array>instead ofArrayWhy did you make the changes (we will use this info to test)?
Octokitto ensure our CI/CD workflow can operate without hiccups.Screenshots of Proposed Changes Of The Website (if any, please do not screenshot code changes)
No Visual Changes
Information for reviewers:
I replicated Hack4LA's project board in my own repo and created four issues to test some use cases:
A manual run of
.github/workflows/schedule-fri-0700.ymlgave the following output, only checking the age of mrodz#5, which is expected behavior.Expand