Add GitHub handle #7186 for Eduardo De La Rosa in home-unite-us.md#7269
Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom Aug 15, 2024
Merged
Add GitHub handle #7186 for Eduardo De La Rosa in home-unite-us.md#7269LRenDO merged 1 commit intohackforla:gh-pagesfrom
LRenDO merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
hkhaung
force-pushed
the
add-github-handle-7186
branch
from
ad6f703 to
096292b
Compare
hkhaung
force-pushed
the
add-github-handle-7186
branch
from
8479e11 to
3537b39
Compare
daras-cu
approved these changes
Aug 14, 2024
Member
daras-cu
left a comment
daras-cu
left a comment
There was a problem hiding this comment.
Hi @hkhaung, everything looks good with your PR, good job!
- Branches are set up correctly for merging
- Original issue is linked in the PR
- Good explanation of changes and note that visuals were not altered
- In testing, the webpage shows no changes
Thanks for working on this issue!
LRenDO
approved these changes
Aug 15, 2024
Member
LRenDO
left a comment
LRenDO
left a comment
There was a problem hiding this comment.
Hi @hkhaung!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- A note was included that there were no visual changes
- The PR request clearly states what was updated
- The PR request states why the changes are being made
Again, nice work and thanks for taking the time to contribute to the website!
del9ra
pushed a commit
to del9ra/website
that referenced
this pull request
Aug 16, 2024
This was referenced Aug 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7186
What changes did you make?
github-handleunder Eduardo De La Rosa inhome-unite-us.mdWhy did you make the changes (we will use this info to test)?
github-handleis a variable for each member of the leadership team and it will eventually replace the github and picture variables, reducing redundancy in the project file.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)