Skip to content

Added 'github-handle' key below name for Flora Osmond#7270

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
8alpreet:github-handle-flora-osmond-7187
Aug 18, 2024
Merged

Added 'github-handle' key below name for Flora Osmond#7270
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
8alpreet:github-handle-flora-osmond-7187

Conversation

@8alpreet
Copy link
Member

@8alpreet 8alpreet commented Aug 11, 2024

Fixes #7187

What changes did you make?

  • I modified _projects/home-unite-us.md by adding 'github-handle' key below the 'name: Flora Osmond' key/value pair.

Why did you make the changes (we will use this info to test)?

  • This change is intended to reduce redundancy in the project file by replacing, in the near future, 'github' and 'picture' key/value pairs.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website. The new key is not part of a display card.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b 8alpreet-github-handle-flora-osmond-7187 gh-pages
git pull https://github.com/8alpreet/website.git github-handle-flora-osmond-7187

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 11, 2024
@alabador
Copy link
Member

Review ETA: End of day Aug 15, 2024
Availability: Thursday, 8 - 11 PM

Copy link
Member

@alabador alabador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @8alpreet , good work on this issue!

  • Branches are set up correctly
  • Issues are linked
  • Reason for changes is clear
  • No visual changes needed as indicated

Thanks for working on this!

@saiteja-siddana
Copy link
Member

Review ETA: 11:59PM PM 08/16/24
Availability: 5-11:59 PM Friday

Copy link
Member

@saiteja-siddana saiteja-siddana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @8alpreet, thanks for working on this. Everything looks good.

  • Into and from branch are done correctly
  • PR explains what you changed and why you changed it
  • Linked to the correct issue
  • Code changes are appropriate to the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Flora Osmond in home-unite-us.md

4 participants