added github-handle for Minji Kim#7272
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @kgold2018 Great job-
- your 'from' and 'to' branches look good
- your descriptions for what you did and why are corect and concise
- you added the note for no visual changes
- your code edit is clean and only changes what needs to be changed.
On the linked issue, i.e. Fixes #7251, I think that you might have added a colon after "Fixes" and this might be tripping up the automation. Would you please remove the colon? Thanks!
FYI I removed the other reviewer you requested b/c they are no longer active. FYI- it is best to avoid asking for specific reviewers, especially when GitHub suggests someone b/c often they are not available. The only exception is when you are asking a specific person for a re-review or if you contacted the person previously and know they are available.
|
@t-will-gillis i have fixed the PR: column(:) was removed and looks like Fixes #7251.Thank you for your input. |
t-will-gillis
left a comment
There was a problem hiding this comment.
Thanks for making the edit!
freaky4wrld
left a comment
There was a problem hiding this comment.
@kgold2018 thanks for making the changes
- branches looks good
- changes made are apt and as specified
- the issue linked is correct
PR approved
Co-authored-by: Klavdia <kgold94@yahoo.com>
Fixes #7251
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not include screenshots of code changes)