Skip to content

added github-handle for Minji Kim#7272

Merged
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
kgold2018:add-github-handle-7251
Aug 13, 2024
Merged

added github-handle for Minji Kim#7272
freaky4wrld merged 1 commit intohackforla:gh-pagesfrom
kgold2018:add-github-handle-7251

Conversation

@kgold2018
Copy link
Member

@kgold2018 kgold2018 commented Aug 11, 2024

Fixes #7251

What changes did you make?

  • Added 'github-handle' under Minji Kim name list section

Why did you make the changes (we will use this info to test)?

  • For future replacement of git-hub and picture variables to reduce redundancy.

Screenshots of Proposed Changes Of The Website (if any, please do not include screenshots of code changes)

  • No visual changes

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b kgold2018-add-github-handle-7251 gh-pages
git pull https://github.com/kgold2018/website.git add-github-handle-7251

@kgold2018 kgold2018 changed the title added github-handle added github-handle for Minji Kim Aug 12, 2024
@t-will-gillis t-will-gillis removed the request for review from adrianang August 12, 2024 19:59
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kgold2018 Great job-

  • your 'from' and 'to' branches look good
  • your descriptions for what you did and why are corect and concise
  • you added the note for no visual changes
  • your code edit is clean and only changes what needs to be changed.

On the linked issue, i.e. Fixes #7251, I think that you might have added a colon after "Fixes" and this might be tripping up the automation. Would you please remove the colon? Thanks!

FYI I removed the other reviewer you requested b/c they are no longer active. FYI- it is best to avoid asking for specific reviewers, especially when GitHub suggests someone b/c often they are not available. The only exception is when you are asking a specific person for a re-review or if you contacted the person previously and know they are available.

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours role: QA labels Aug 12, 2024
@kgold2018
Copy link
Member Author

kgold2018 commented Aug 12, 2024

@t-will-gillis i have fixed the PR: column(:) was removed and looks like Fixes #7251.Thank you for your input.

@t-will-gillis t-will-gillis self-requested a review August 12, 2024 21:12
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the edit!

@freaky4wrld freaky4wrld self-requested a review August 13, 2024 04:54
Copy link
Member

@freaky4wrld freaky4wrld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kgold2018 thanks for making the changes

  • branches looks good
  • changes made are apt and as specified
  • the issue linked is correct

PR approved

@freaky4wrld freaky4wrld merged commit 08620ac into hackforla:gh-pages Aug 13, 2024
del9ra pushed a commit to del9ra/website that referenced this pull request Aug 16, 2024
Co-authored-by: Klavdia <kgold94@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers role: QA size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Minji Kim in tech-work-experience.md

4 participants