Skip to content

add github handle #7254#7285

Merged
LRenDO merged 1 commit intohackforla:gh-pagesfrom
pluto-bell:add-githandle-7254
Aug 15, 2024
Merged

add github handle #7254#7285
LRenDO merged 1 commit intohackforla:gh-pagesfrom
pluto-bell:add-githandle-7254

Conversation

@pluto-bell
Copy link
Member

Fixes #7254

What changes did you make?

  • added 'github-handle' under Eric Vennemeyer's name, located under the "Tech Work Expereince" project.

Why did you make the changes (we will use this info to test)?

  • To reduce redundancy in the project file.

Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes were made.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b pluto-bell-add-githandle-7254 gh-pages
git pull https://github.com/pluto-bell/hack4la.git add-githandle-7254

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 14, 2024
@Anahisv23 Anahisv23 self-requested a review August 14, 2024 19:46
@Anahisv23
Copy link
Member

ETA: EOD

@pluto-bell
Copy link
Member Author

@t-will-gillis I hope you don't mind that I've requested you again — just looking to move into meatier issues as soon as possible and I notice you as one of the more active members/mergers. Let me know if you'd like me to pause on sending you requests!

Cheers *~

Copy link
Member

@Anahisv23 Anahisv23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pluto-bell, thanks for working on this issue. Everything looks good on my end. Nice work!

What went well

  • Into and from branch are set up correctly
  • PR description is detailed and explains why the changes are needed and what you changed
  • Appropriate lines of code were changed to add the github-handle variable

@LRenDO LRenDO self-requested a review August 15, 2024 15:14
Copy link
Member

@LRenDO LRenDO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @pluto-bell!
Great job with this pull request!

  • The branching was done correctly
  • Issue number was listed
  • The PR title is descriptive of the changes
  • Changes were made correctly in the code
  • A note was included that there were no visual changes
  • The PR request clearly states what was updated
  • The PR request states why the changes are being made

I have one non-functional request for the future. Please be more specific with the title. For example, "added github handle for Eric Vennemeyer in tech-work-experience.md". We often have many very similar issues and it's helpful to have some specificity in the title.

Again, nice work and thanks for taking the time to contribute to the website!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Eric Vennemeyer in tech-work-experience.md

3 participants