Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
ETA: EOD |
|
@t-will-gillis I hope you don't mind that I've requested you again — just looking to move into meatier issues as soon as possible and I notice you as one of the more active members/mergers. Let me know if you'd like me to pause on sending you requests! Cheers *~ |
Anahisv23
left a comment
There was a problem hiding this comment.
Hi @pluto-bell, thanks for working on this issue. Everything looks good on my end. Nice work!
What went well
- Into and from branch are set up correctly
- PR description is detailed and explains why the changes are needed and what you changed
- Appropriate lines of code were changed to add the
github-handlevariable
LRenDO
left a comment
There was a problem hiding this comment.
Hi @pluto-bell!
Great job with this pull request!
- The branching was done correctly
- Issue number was listed
- The PR title is descriptive of the changes
- Changes were made correctly in the code
- A note was included that there were no visual changes
- The PR request clearly states what was updated
- The PR request states why the changes are being made
I have one non-functional request for the future. Please be more specific with the title. For example, "added github handle for Eric Vennemeyer in tech-work-experience.md". We often have many very similar issues and it's helpful to have some specificity in the title.
Again, nice work and thanks for taking the time to contribute to the website!
Fixes #7254
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes were made.