Added github-handle property for Andrew Salvatore#7293
Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom Aug 21, 2024
Merged
Added github-handle property for Andrew Salvatore#7293roslynwythe merged 1 commit intohackforla:gh-pagesfrom
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
Member
|
ETA: EOD |
Anahisv23
approved these changes
Aug 15, 2024
Member
Anahisv23
left a comment
There was a problem hiding this comment.
Hi @saiteja-siddana, thank you for working on this issue. Everything looks good on my end. Nice work!
What went well
- Into and from branch are set up correctly
- PR explains what you changed and why you changed it
- PR is linked to the correct issue number
- Appropriate lines of code were changed to add the
github-handlevariable
Member
|
Review ETA: EOD |
8alpreet
approved these changes
Aug 19, 2024
Member
There was a problem hiding this comment.
Hi @saiteja-siddana,
What went well:
- Into and from branch are set up correctly
- PR explains what you changed and why you changed it
- PR is linked to the correct issue number
- Only relevant lines of code were changed to add the github-handle variable
Additional feedback
- I love the details ("property" and name of team member) you provided in the PR title
- The use of specific language such a "key" and "value" demonstrates your understanding of the changes and builds a shared context with the reviewer
This was referenced Aug 20, 2024
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7246
What changes did you make?
_projects/tech-work-experience.mdby adding 'github-handle' key below the 'name: Andrew Salvatore' key/value pair.Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)