Add github-handle variable to Jessie Liu#7299
Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom Aug 18, 2024
Merged
Add github-handle variable to Jessie Liu#7299t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
good first issue
mrodz
approved these changes
Aug 15, 2024
Member
mrodz
left a comment
mrodz
left a comment
There was a problem hiding this comment.
Hello @minkang3, thank you for picking this up!
- Correctly inserted
github-handleYAML property to Jessie Liu's object, used spaces instead of tabs - Correct to/from branches
- Linked issue number
- Good explanation of changes
Approving because this PR looks solid. Good luck with future tickets!
31 tasks
Member
|
Review ETA: 10pm 8/17/24 |
mmcclanahan
approved these changes
Aug 18, 2024
Member
mmcclanahan
left a comment
mmcclanahan
left a comment
There was a problem hiding this comment.
@minkang3, good work!
To and from branches are correct
Used spaces to indent the github-handle
Correctly linked issue
Clear why and how explanation of changes
No visual changes to website
Nice!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7250
What changes did you make?
github-handlefor Jessie Liu in _projects/tech-work-experience.mdWhy did you make the changes (we will use this info to test)?
githubandpictureto just one variable,github-handle.Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes.