Add Github Handle for Nino Dzotsenidze in tech-work-experience.md#7306
Add Github Handle for Nino Dzotsenidze in tech-work-experience.md#7306jphamtv merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Availability: Weekdays 5pm-9pm, Weekends 10am-5pm |
|
Review ETA: EOD |
mrodz
left a comment
There was a problem hiding this comment.
Hi @izma-mujeeb! Good work on this issue.
- Correctly linked issue number
- Correct to/from branches
- Correctly modified Nino Dzotsenidze's yaml object, added
github-handle - Correctly used spaces
- Good description of the issue (for future issues, if you don't have enough items in the bullet point list, you can remove the extra
-)
Keep it up :)
mmcclanahan
left a comment
There was a problem hiding this comment.
Hey @izma-mujeeb!
Great job adding the github-handle.
One quick thing that could be changed for clarity is the PR name. Adding whose github handle variable was added would be helpful for readers. Such as: Added Github Handle Variable for Nino Dzotsenidze
There was a problem hiding this comment.
Hi @izma-mujeeb,
What went well:
- Into branch is set up correctly.
- PR is linked to the correct issue number.
- Branch is named correctly
- Only relevant lines of code were changed.
Changes needed:
- In the "why did you make these changes" section
- You're correct in stating the purpose of the "github-handle" key; however, the full reason for the change is not being communicated. It would be great to have the true "why" of the change. This section should allow the reader/reviewer to get the gist of the related issue without having to open the issue itself.
|
ETA: EOD |
minkang3
left a comment
There was a problem hiding this comment.
Everything looks good except the "Why did you make the changes" section in your PR.
The language "We needed..." doesn't show a clear understanding of the issue and why it needed to be fixed. Rather than saying you did the changes because you needed to, look for the underlying problem that is being fixed.
8alpreet
left a comment
There was a problem hiding this comment.
Thank you for applying the feedback!
Fixes #7253
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)
No visual changes to the website