Skip to content

Add Samuel kowitch GitHub handle #7189#7345

Merged
jphamtv merged 4 commits intohackforla:gh-pagesfrom
FamousHero:samuel_kowitch_github_handle_7189
Aug 29, 2024
Merged

Add Samuel kowitch GitHub handle #7189#7345
jphamtv merged 4 commits intohackforla:gh-pagesfrom
FamousHero:samuel_kowitch_github_handle_7189

Conversation

@FamousHero
Copy link
Member

@FamousHero FamousHero commented Aug 23, 2024

Fixes #7189

What changes did you make?

  • Add "github-handle:" below " - name: Samuel Kowitch" in home-unite-us.md

Why did you make the changes (we will use this info to test)?

  • Future plans to remove github & picture fields to reduce redundancy

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b FamousHero-samuel_kowitch_github_handle_7189 gh-pages
git pull https://github.com/FamousHero/H4LAwebsite.git samuel_kowitch_github_handle_7189

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) ready for dev lead Issues that tech leads or merge team members need to follow up on size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 23, 2024
@kgold2018 kgold2018 self-requested a review August 24, 2024 00:26
Copy link
Member

@kgold2018 kgold2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @FamousHero , thanks for taking this issue!

What looks good:

  • Your branches are set up correctly

  • The original issue number is linked in the pull request

Things you should change:

  • There are changes to multiple other lines in home-unite-us.md not called for in the issue.
    Just a note, in your pull request below, changes you made are not per requirement
  • name: Samuel Kowitch
    github: KowDesign

Once you've fixed the extra changes to the file, let me know in a comment or re-request a review.

@FamousHero
Copy link
Member Author

@kgold2018 Thanks for the feedback! I removed the changes that we not a part of the original requirement.

@FamousHero FamousHero requested a review from kgold2018 August 24, 2024 01:27
@terrencejihoonjung terrencejihoonjung self-requested a review August 24, 2024 04:31
@terrencejihoonjung
Copy link
Member

Review ETA: 8/24/24, 11:59pm PT
Availability: 9am-5pm everyday

Copy link
Member

@terrencejihoonjung terrencejihoonjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FamousHero,

  • "from and to" branching is correct

Changes Requested:

  • as of now, it seems the change requirements have still not been met. I recommend re-reading the issue instructions to see the small change needed.

Note: For your next PR, I recommend using hyphens rather than underscores when naming your branches to follow the common convention among hack-for-la issues.

Thank you for your contribution!

Copy link
Member

@kgold2018 kgold2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FamousHero,
I reviewed your last changes after @[terrencejihoonjung comments - it looks good now.
Thank you!

@t-will-gillis
Copy link
Member

Hey @FamousHero please don't forget to re-request a review after you have made changes by selecting the chasing arrows next to the reviewer's handle:
Screenshot 2024-08-25 083539

@t-will-gillis t-will-gillis removed the ready for dev lead Issues that tech leads or merge team members need to follow up on label Aug 26, 2024
@codyyjxn codyyjxn self-requested a review August 27, 2024 02:06
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Everything looks great !

@codyyjxn
Copy link
Member

Review ETA: 8/26/24, 11:59pm PT
Availability: 9am-5pm M > F

Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Approved.

@jphamtv jphamtv dismissed terrencejihoonjung’s stale review August 29, 2024 23:17

Requested changes satisfied and approved by multiple reviewers

@jphamtv jphamtv removed the request for review from terrencejihoonjung August 29, 2024 23:17
@jphamtv jphamtv merged commit 15561ad into hackforla:gh-pages Aug 29, 2024
@FamousHero FamousHero deleted the samuel_kowitch_github_handle_7189 branch September 1, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Samuel Kowitch in home-unite-us.md

7 participants