Skip to content

Add github-handle for Jane He in tdm-calculator.md #7347

Merged
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
vorleakyek:add-github-handle-Jane-He-tdm-calculator-7170
Aug 25, 2024
Merged

Add github-handle for Jane He in tdm-calculator.md #7347
roslynwythe merged 1 commit intohackforla:gh-pagesfrom
vorleakyek:add-github-handle-Jane-He-tdm-calculator-7170

Conversation

@vorleakyek
Copy link
Member

Fixes #7170

What changes did you make?

  • Replace - name: Jane He with
- name: Jane He
  github-handle:

Why did you make the changes (we will use this info to test)?

  • To create a single variable github-handle
  • Eventually github-handle will replace the github and picture variables

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

Adding the github-handle: in the tdm-calculator.md file. No visual changes to the website.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b vorleakyek-add-github-handle-Jane-He-tdm-calculator-7170 gh-pages
git pull https://github.com/vorleakyek/website.git add-github-handle-Jane-He-tdm-calculator-7170

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 24, 2024
@tamara-snyder tamara-snyder self-requested a review August 24, 2024 18:20
@tamara-snyder
Copy link
Member

Review ETA: End of day Aug 24, 2024
Availability: 12-3PM PT

@palakkeni5
Copy link
Member

Review ETA: Aug 24, 2024 6PM EST
Availability: 5PM - 8 PM EST

@palakkeni5
Copy link
Member

Checklist

  • Is the pull request done with the correct branch? Yes
  • Is there a linked issue? Fixes Add github-handle for Jane He in tdm-calculator.md #7170
  • Understand the linked issue.
  • View the changes in the browser.
  • Take a look at files changed tab.
  • Check for anything else.
  • Approve the pull request.
  • Clean up your working

Hi @vorleakyek ,

Your PR looks fine to me.

Thanks for working on the issue!

P.S : This is my first PR review in the organization. I do not see options to approve this request as mentioned in the steps.

@bexux bexux self-requested a review August 25, 2024 00:06
@bexux
Copy link
Member

bexux commented Aug 25, 2024

Review ETA: Aug 24, 2024 6PM PST
Availability: 6PM - 8 PM PST

Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. You followed all the steps - approved.

Copy link
Member

@tamara-snyder tamara-snyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can see that you added the github-handle line in the right place and that the appearance of the webpage is unchanged. Nice work!

@roslynwythe roslynwythe merged commit 793b632 into hackforla:gh-pages Aug 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Jane He in tdm-calculator.md

5 participants