Add github handle for Joshua Fishman in tech-work-experience#7350
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Looks good @vorleakyek! The pull request is written correctly, I verified that you made the correct changes to the site, and it did not change the appearance. Thanks for working on this! |
bexux
left a comment
There was a problem hiding this comment.
Great job! PR description is well written, issue is linked, branches are correct, and the changes are made correctly in the correct file.
codyyjxn
left a comment
There was a problem hiding this comment.
Nice work! I wanted to mention that it might be helpful to simplify the branch names for future reference. It could make it easier for everyone to identify and work with them quickly.
Just a small suggestion to consider—thanks for all your hard work!
|
Review ETA: 8/26/24, 11:59pm PT |
kgold2018
left a comment
There was a problem hiding this comment.
Hi @vorleakyek ! You followed all the steps - approved.
I can see that you added the GitHub handle line in the right place and that the webpage's appearance has remained unchanged. Thank you!
|
Hey @vorleakyek For future reference- please do not request a review from anyone unless you have already contacted that person, or if you need a re-review from that person. I am mentioning this because one of the reviewers you requested is no longer active, so you would be waiting a very long time for them to review your PR. |
|
Thanks @t-will-gillis, but I don't think I requested a review from anyone. I thought it was automated after I opened the PR. |
|
Hi @vorleakyek My mistake! One of the other reviewers requested that person, not you. |
Fixes #7240
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)