Skip to content

Add github handle for Joshua Fishman in tech-work-experience#7350

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
vorleakyek:add-github-handle-Joshua-Fishman-tech-work-experience-7240
Aug 27, 2024
Merged

Add github handle for Joshua Fishman in tech-work-experience#7350
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
vorleakyek:add-github-handle-Joshua-Fishman-tech-work-experience-7240

Conversation

@vorleakyek
Copy link
Member

Fixes #7240

What changes did you make?

  • adding "github-handle:" under "- name: Joshua Fishman" in the tech-work-experience.md

Why did you make the changes (we will use this info to test)?

  • to create a single variable github-handle to hold the github handle
  • github-handle will replace the github and picture variables

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b vorleakyek-add-github-handle-Joshua-Fishman-tech-work-experience-7240 gh-pages
git pull https://github.com/vorleakyek/website.git add-github-handle-Joshua-Fishman-tech-work-experience-7240

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 25, 2024
@k-cardon k-cardon requested review from adrianang and k-cardon August 26, 2024 04:50
@k-cardon
Copy link
Member

Looks good @vorleakyek! The pull request is written correctly, I verified that you made the correct changes to the site, and it did not change the appearance. Thanks for working on this!

Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct!

@bexux bexux self-requested a review August 26, 2024 15:11
Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! PR description is well written, issue is linked, branches are correct, and the changes are made correctly in the correct file.

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I wanted to mention that it might be helpful to simplify the branch names for future reference. It could make it easier for everyone to identify and work with them quickly.

Just a small suggestion to consider—thanks for all your hard work!

@codyyjxn
Copy link
Member

Review ETA: 8/26/24, 11:59pm PT
Availability: 9am-5pm M > F

Copy link
Member

@kgold2018 kgold2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @vorleakyek ! You followed all the steps - approved.
I can see that you added the GitHub handle line in the right place and that the webpage's appearance has remained unchanged. Thank you!

@t-will-gillis
Copy link
Member

Hey @vorleakyek For future reference- please do not request a review from anyone unless you have already contacted that person, or if you need a re-review from that person.

I am mentioning this because one of the reviewers you requested is no longer active, so you would be waiting a very long time for them to review your PR.

@t-will-gillis t-will-gillis removed the request for review from adrianang August 27, 2024 17:06
@t-will-gillis t-will-gillis merged commit 806c8b9 into hackforla:gh-pages Aug 27, 2024
@vorleakyek
Copy link
Member Author

Thanks @t-will-gillis, but I don't think I requested a review from anyone. I thought it was automated after I opened the PR.

@t-will-gillis
Copy link
Member

Hi @vorleakyek

My mistake! One of the other reviewers requested that person, not you.

@vorleakyek vorleakyek deleted the add-github-handle-Joshua-Fishman-tech-work-experience-7240 branch August 28, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Joshua Fishman in tech-work-experience.md

6 participants