Skip to content

add github handle, Hyun Joo Sandy Oh#7364

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
k-cardon:github-handle-7242
Aug 29, 2024
Merged

add github handle, Hyun Joo Sandy Oh#7364
jphamtv merged 1 commit intohackforla:gh-pagesfrom
k-cardon:github-handle-7242

Conversation

@k-cardon
Copy link
Member

@k-cardon k-cardon commented Aug 29, 2024

Fixes #7242

What changes did you make?

  • adds github-handle variable for Hyun Joo Sandy Oh in tech-work-experience.md

Why did you make the changes (we will use this info to test)?

  • fixing technical debt

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b k-cardon-github-handle-7242 gh-pages
git pull https://github.com/k-cardon/hack4LA-website.git github-handle-7242

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 29, 2024
@bexux bexux self-requested a review August 29, 2024 15:25
@bexux
Copy link
Member

bexux commented Aug 29, 2024

Availability: M-F 6-7pm PST
ETA: now

Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Branch is correct, PR description reads well, correct changes ere made to the correct file. Approved.

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @k-cardon,

  • You created the pull request using the correct branch
  • The issue is properly linked to the pull request
  • Your code change correctly uses spaces instead of tabs

One minor suggestion for future PRs: Provide a more specific summary for the "Why did you make the changes?" question. You can usually get this from the Overview section in the issue. For example, for this one I would comment: "Add github-handle variable to reduce redundancy."

Good work and thanks for your contribution to resolving this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Hyun Joo Sandy Oh in tech-work-experience.md

3 participants