Skip to content

added github-handle property for Robert Schacht#7365

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
saiteja-siddana:add-github-handle-7292
Aug 29, 2024
Merged

added github-handle property for Robert Schacht#7365
jphamtv merged 1 commit intohackforla:gh-pagesfrom
saiteja-siddana:add-github-handle-7292

Conversation

@saiteja-siddana
Copy link
Member

Fixes #7292

What changes did you make?

  • I modified _projects/design-systems.md by adding 'github-handle' key below the 'name: Robert Schacht' key/value pair.

Why did you make the changes (we will use this info to test)?

  • This change is intended to reduce redundancy in the project file by replacing 'github' and 'picture' key/value pairs.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website. The new key is not part of a display card.

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b saiteja-siddana-add-github-handle-7292 gh-pages
git pull https://github.com/saiteja-siddana/website.git add-github-handle-7292

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 29, 2024
@k-cardon k-cardon self-requested a review August 29, 2024 16:46
@k-cardon
Copy link
Member

Hi Saiteja, this looks good! Pull request written correctly, code corrects the issue, and I verified that your branch does not change the appearance of the website.

Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct!

Copy link
Member

@jphamtv jphamtv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @saiteja-siddana,

  • You created the pull request using the correct branch
  • The issue is properly linked to the pull request
  • Your summary of changes is clear and concise
  • Your code change correctly uses spaces instead of tabs

Great work. Thanks for your contribution to resolving this issue!

@jphamtv jphamtv merged commit 7dbf682 into hackforla:gh-pages Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Robert Schacht in design-systems.md

3 participants