Skip to content

added github handle for Priyanka Talwar - not Bryanna#7369

Merged
jphamtv merged 1 commit intohackforla:gh-pagesfrom
NolaDodd:update-bryanna-7248
Sep 12, 2024
Merged

added github handle for Priyanka Talwar - not Bryanna#7369
jphamtv merged 1 commit intohackforla:gh-pagesfrom
NolaDodd:update-bryanna-7248

Conversation

@NolaDodd
Copy link
Member

@NolaDodd NolaDodd commented Aug 30, 2024

Fixes #7248

What changes did you make?

UPDATE*** Merge Team changed title to reference "Priyanka Talwar"

Why did you make the changes (we will use this info to test)?

  • To add a place for Priyanka to add her Github handle. Eventually, the github-handle will replace the github and picture variables, reducing redundancy in the project file.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b NolaDodd-update-bryanna-7248 gh-pages
git pull https://github.com/NolaDodd/website.git update-bryanna-7248

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 30, 2024
@andyphancode andyphancode self-requested a review August 30, 2024 21:49
@andyphancode
Copy link
Member

Review ETA: 8/30/24 EOD
Availability: throughout week

@andyphancode
Copy link
Member

Branches look good, correct addition to Priyanka. Good catch on the inconsistency of names. @roslynwythe did they select the proper individual to add github-handle to, or was the issue intended to change for Bryanna Lim?

For @NolaDodd , please add a "Why did you make the changes (we will use this info to test)?" regularly to pull requests. A good idea would be "Added a github handle label to hold github profile link of person" or whatever you see appropriate.

@NolaDodd
Copy link
Member Author

Branches look good, correct addition to Priyanka. Good catch on the inconsistency of names. @roslynwythe did they select the proper individual to add github-handle to, or was the issue intended to change for Bryanna Lim?

For @NolaDodd , please add a "Why did you make the changes (we will use this info to test)?" regularly to pull requests. A good idea would be "Added a github handle label to hold github profile link of person" or whatever you see appropriate.

Added the "Why" for the request, thank you!

@t-will-gillis
Copy link
Member

t-will-gillis commented Sep 2, 2024

Hi @NolaDodd (and @andyphancode , @roslynwythe ) Thanks for pointing out the mix up. The issue title is now updated to #7248, and also updated the issue and issue title for #7239 to address "Bryanna Lin"

@8alpreet 8alpreet self-requested a review September 3, 2024 15:34
@8alpreet
Copy link
Member

8alpreet commented Sep 3, 2024

Review ETA: EOD Sep 4, 2024
Availability: 3pm to 7pm weekdays

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NolaDodd,

What went well:

  • Correct lines of code were changed.
  • PR title is descriptive and concise.
  • Branch is named correctly.
  • Related issue is linked.

Changed Needed:

  1. Why section:
    • your why section is very similar to your what section because it describes what you did not why you did it. I know the distinction is blurry on these good first issue, but the why is the cause of the changes. Let's say for example, that some elements in the website were having weird sizing issue on mobile devices. You figure out that some CSS in file X is the cause. So your what would be: I changed _____ in file X. Your why should explain why it was those lines of code that needed to be changed.
  2. Screenshots section:
    • you don't need the quotes around "- No visual changes..."

@k-cardon k-cardon self-requested a review September 4, 2024 19:48
Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct, @NolaDodd! You branched correctly, added the correct lines of code, used spaces instead of indent, and I confirmed no visual changes to site.

Since Balpreet wants a change to the "why" section of the pull request, you could pull text from the issue, which explains why the site is updating the github-handle variable:

"Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file."

Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NolaDodd Nice this looks good! The title is concise and the pr is good !

@Thinking-Panda
Copy link
Member

@NolaDodd Please make requested changes and re-request a review.

@NolaDodd NolaDodd requested a review from 8alpreet September 11, 2024 21:54
Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Things look great now, thanks for applying the feedback!

@jphamtv jphamtv merged commit e4af699 into hackforla:gh-pages Sep 12, 2024
@NolaDodd NolaDodd deleted the update-bryanna-7248 branch November 17, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Priyanka Talwar in tech-work-experience.md REVISED

8 participants