Add Github Handle for Gala Stojnic in design-systems.md#7371
Merged
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom Sep 4, 2024
Merged
Add Github Handle for Gala Stojnic in design-systems.md#7371Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
vorleakyek
approved these changes
Aug 31, 2024
Member
vorleakyek
left a comment
There was a problem hiding this comment.
It looks good! Approved!
One minor thing, including the person's name in the branch name for clarity might be good.
Thanks for contributing!
Member
|
Review ETA: EOD Sep 4, 2024 |
8alpreet
suggested changes
Sep 4, 2024
Member
8alpreet
left a comment
There was a problem hiding this comment.
Hi @izma-mujeeb,
What went well:
- PR title is descriptive and concise.
- Branch is named correctly.
- Correct line of code was changed.
- Issue is linked in PR comment.
- What section is answered well.
Changes Needed:
- Why section:
- I appreciate the level of detail you provided in this section; however, it is slightly inaccurate. The
github-handlevariable is not used to hold github and picture variables. Rather, that variable will replace both of the variables in the future.
- I appreciate the level of detail you provided in this section; however, it is slightly inaccurate. The
8alpreet
approved these changes
Sep 4, 2024
Member
8alpreet
left a comment
There was a problem hiding this comment.
Looks good. Thanks for applying the feedback!
k-cardon
approved these changes
Sep 4, 2024
Member
k-cardon
left a comment
There was a problem hiding this comment.
Everything looks good to go! Branch is correct, line added correctly with spaces not tab, no visual changes to the site.
This was referenced Aug 10, 2025
34 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7287
What changes did you make?
Why did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)