Skip to content

Add Github Handle for Gala Stojnic in design-systems.md#7371

Merged
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
izma-mujeeb:add-github-handle-7287
Sep 4, 2024
Merged

Add Github Handle for Gala Stojnic in design-systems.md#7371
Thinking-Panda merged 1 commit intohackforla:gh-pagesfrom
izma-mujeeb:add-github-handle-7287

Conversation

@izma-mujeeb
Copy link
Member

@izma-mujeeb izma-mujeeb commented Aug 31, 2024

Fixes #7287

What changes did you make?

  • Using spaces, I added a variable called github-handle to hold Gala Stojnic's github handle

Why did you make the changes (we will use this info to test)?

  • The reason why I needed to add a variable to hold the github-handle was because the github-handle variable is used to replace each member in the leadership team's github and picture variables in the future. By replacing the github and picture variables, I am ensuring that the code is efficient and reducing any redundant code in the project file.

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b izma-mujeeb-add-github-handle-7287 gh-pages
git pull https://github.com/izma-mujeeb/website.git add-github-handle-7287

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Aug 31, 2024
@vorleakyek vorleakyek self-requested a review August 31, 2024 04:20
Copy link
Member

@vorleakyek vorleakyek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good! Approved!
One minor thing, including the person's name in the branch name for clarity might be good.
Thanks for contributing!

@8alpreet
Copy link
Member

8alpreet commented Sep 3, 2024

Review ETA: EOD Sep 4, 2024
Availability: 3pm to 7pm weekdays

Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @izma-mujeeb,

What went well:

  • PR title is descriptive and concise.
  • Branch is named correctly.
  • Correct line of code was changed.
  • Issue is linked in PR comment.
  • What section is answered well.

Changes Needed:

  1. Why section:
    • I appreciate the level of detail you provided in this section; however, it is slightly inaccurate. The github-handle variable is not used to hold github and picture variables. Rather, that variable will replace both of the variables in the future.

@izma-mujeeb izma-mujeeb requested a review from 8alpreet September 4, 2024 16:43
Copy link
Member

@8alpreet 8alpreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for applying the feedback!

@k-cardon k-cardon self-requested a review September 4, 2024 21:07
Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to go! Branch is correct, line added correctly with spaces not tab, no visual changes to the site.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Gala Stojnic in design-systems.md

5 participants