Skip to content

Added GitHub Handle for Liz Zheng in design-systems.md#7406

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
terrencejihoonjung:add-github-handle-7290
Sep 9, 2024
Merged

Added GitHub Handle for Liz Zheng in design-systems.md#7406
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
terrencejihoonjung:add-github-handle-7290

Conversation

@terrencejihoonjung
Copy link
Member

Fixes #7290

What changes did you make?

  • Added github-handle field under the name field for Liz Zheng in design-systems.md

Why did you make the changes (we will use this info to test)?

  • To hold the GitHub handle for each member of the leadership team

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

No visual changes made.

@github-actions
Copy link

github-actions bot commented Sep 6, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b terrencejihoonjung-add-github-handle-7290 gh-pages
git pull https://github.com/terrencejihoonjung/website.git add-github-handle-7290

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 6, 2024
@codyyjxn codyyjxn self-requested a review September 6, 2024 21:37
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrencejihoonjung
Good Job! This looks good! The title is concise and the branch name is correct.

@bexux bexux self-requested a review September 7, 2024 17:59
Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Issue linked, followed directions well, clear PR description. Nicely done.

@handshek handshek self-requested a review September 7, 2024 18:20
Copy link
Member

@handshek handshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@terrencejihoonjung Good one!

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clear and concise description of what was done and why
  • No visual changes were made to the website

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Liz Zheng in design-systems.md

5 participants