Skip to content

7183: Add github-handle for Raji Pradheap in home-unite-us.md#7408

Merged
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
tamara-snyder:add-github-handle-raji-pradheap-7183
Sep 9, 2024
Merged

7183: Add github-handle for Raji Pradheap in home-unite-us.md#7408
t-will-gillis merged 1 commit intohackforla:gh-pagesfrom
tamara-snyder:add-github-handle-raji-pradheap-7183

Conversation

@tamara-snyder
Copy link
Member

Fixes #7183

What changes did you make?

Replaced:

- name: Raji Pradheap

with

- name: Raji Pradheap
  github-handle:

Why did you make the changes (we will use this info to test)?

  • To create a single variable github-handle to hold the github handle for each member of the leadership team

  • Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file

  • Screenshots of Proposed Changes Of The Website (if any, please do not screen shot code changes)

No visual changes to the website.

@tamara-snyder tamara-snyder self-assigned this Sep 7, 2024
@github-actions
Copy link

github-actions bot commented Sep 7, 2024

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b tamara-snyder-add-github-handle-raji-pradheap-7183 gh-pages
git pull https://github.com/tamara-snyder/website.git add-github-handle-raji-pradheap-7183

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Sep 7, 2024
@tamara-snyder tamara-snyder removed their assignment Sep 7, 2024
@bexux bexux self-requested a review September 7, 2024 17:54
Copy link
Member

@bexux bexux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Correct branch, followed instructions, clear PR description. Nicely done.

@codyyjxn codyyjxn self-requested a review September 7, 2024 19:47
Copy link
Member

@codyyjxn codyyjxn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tamara-snyder
Great job on the branch! The changes look solid overall. One suggestion I have is regarding the title: it would be best not to include the issue number in it. Otherwise, everything looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Raji Pradheap in home-unite-us.md

4 participants