Skip to content

Post PBB Migration 7079 - Refactor GHA for Moving Closed Issues#7493

Merged
t-will-gillis merged 14 commits intohackforla:gh-pagesfrom
DrAcula27:post-pbb-migration-7079
Sep 21, 2024
Merged

Post PBB Migration 7079 - Refactor GHA for Moving Closed Issues#7493
t-will-gillis merged 14 commits intohackforla:gh-pagesfrom
DrAcula27:post-pbb-migration-7079

Conversation

@DrAcula27
Copy link
Member

Fixes #7079

What changes did you make?

  • Refactored .github/workflows/move-closed-issues.yaml to use the GraphQL API to move closed issues to either the Done column or the QA column in the project board.
  • Created github-actions/move-closed-issues/move-closed-issues.js to perform the action of moving the closed issues
    • This file incorporates ../utils/_data/status-field-ids.js, ../utils/query-issue-info.js, and ../utils/mutate-issue-status.js
  • Refactored how the owner and repo variables were named in query-issue-info.js
  • Renamed the projectItem variable in query-issue-info.js to projectData
  • Pulled updates from the main repo that were made in mutate-issue-status.js

Why did you make the changes (we will use this info to test)?

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b DrAcula27-post-pbb-migration-7079 gh-pages
git pull https://github.com/DrAcula27/website.git post-pbb-migration-7079

@github-actions github-actions bot added role: back end/devOps Tasks for back-end developers Complexity: Large time sensitive Needs to be worked on by a particular timeframe Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms size: 3pt Can be done in 13-18 hours Feature: API Coding requires using an API labels Sep 18, 2024
Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DrAcula27 Great job and thanks for your work on this up till now! Just a couple comments:

  • In query-issue-info.js there is a doubly declared statusName- please delete the second one, line 53. (You might need to manually fix the CodeQL errors if they do not resolve after CodeQL reruns.)
  • Thanks for changing the name of projectsItemsprojectData and adding the constants for repoOwner and repoName.
  • For move-closed-issues.js, not major but could you delete the blank line 8?
  • Same file, could you add some JSDoc to main(), something like the following but feel free to edit it:
/**
 * Changes the closed 'status' of the issue based on `sort-closed-issues.js`
 * @param {Object} github - github object from actions/github-script
 * @param {Object} context - context object from actions/github-script
 * @param {String} results - status to which issue will be sorted from prev. step
 * 
 */  

Thanks again!

@DrAcula27
Copy link
Member Author

@t-will-gillis
Requested changes have been made, and I re-requested your review. Thank you for your comments!
It also looks like the CodeQL errors resolved 👍

Copy link
Member

@t-will-gillis t-will-gillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @DrAcula27 Thanks for making the edits and taking care of CodeQL- looks great!

@t-will-gillis t-will-gillis merged commit d8ebc2c into hackforla:gh-pages Sep 21, 2024
@DrAcula27 DrAcula27 deleted the post-pbb-migration-7079 branch September 23, 2024 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complexity: Large Feature: API Coding requires using an API Feature: Board/GitHub Maintenance Project board maintenance that we have to do repeatedly Feature: Refactor GHA Refactoring GitHub actions to fit latest architectural norms Lang: GHA GitHub Actions role: back end/devOps Tasks for back-end developers size: 3pt Can be done in 13-18 hours time sensitive Needs to be worked on by a particular timeframe

Projects

Development

Successfully merging this pull request may close these issues.

Post PBB migration: Refactor "Move Closed Issues" workflow

3 participants