Post PBB Migration 7079 - Refactor GHA for Moving Closed Issues#7493
Merged
t-will-gillis merged 14 commits intohackforla:gh-pagesfrom Sep 21, 2024
Merged
Post PBB Migration 7079 - Refactor GHA for Moving Closed Issues#7493t-will-gillis merged 14 commits intohackforla:gh-pagesfrom
t-will-gillis merged 14 commits intohackforla:gh-pagesfrom
Conversation
…post-pbb-migration-7079
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
t-will-gillis
requested changes
Sep 19, 2024
Member
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @DrAcula27 Great job and thanks for your work on this up till now! Just a couple comments:
- In
query-issue-info.jsthere is a doubly declaredstatusName- please delete the second one, line 53. (You might need to manually fix the CodeQL errors if they do not resolve after CodeQL reruns.) - Thanks for changing the name of
projectsItemsprojectDataand adding the constants forrepoOwnerandrepoName. - For
move-closed-issues.js, not major but could you delete the blank line 8? - Same file, could you add some JSDoc to
main(), something like the following but feel free to edit it:
/**
* Changes the closed 'status' of the issue based on `sort-closed-issues.js`
* @param {Object} github - github object from actions/github-script
* @param {Object} context - context object from actions/github-script
* @param {String} results - status to which issue will be sorted from prev. step
*
*/
Thanks again!
…7/website; branch 'gh-pages' of https://github.com/hackforla/website into post-pbb-migration-7079
Member
Author
|
@t-will-gillis |
t-will-gillis
approved these changes
Sep 21, 2024
Member
t-will-gillis
left a comment
There was a problem hiding this comment.
Hey @DrAcula27 Thanks for making the edits and taking care of CodeQL- looks great!
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7079
What changes did you make?
.github/workflows/move-closed-issues.yamlto use the GraphQL API to move closed issues to either theDonecolumn or theQAcolumn in the project board.github-actions/move-closed-issues/move-closed-issues.jsto perform the action of moving the closed issues../utils/_data/status-field-ids.js,../utils/query-issue-info.js, and../utils/mutate-issue-status.jsownerandrepovariables were named inquery-issue-info.jsprojectItemvariable inquery-issue-info.jstoprojectDatamutate-issue-status.jsWhy did you make the changes (we will use this info to test)?
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)