Added github-handle for Mary Kate Leibman in open-community-survey.md#7822
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
handshek
left a comment
There was a problem hiding this comment.
Hey @jmarinit, great work!
There's just one small change to make: Instead of saying "It was requested in the issue," please provide the actual reason for the changes. You can check the overview section of the issue to understand why these changes were requested.
Ping me once you've made the changes, and I'll go ahead and approve your PR.
There was a problem hiding this comment.
@jmarinit, thank you for helping on this issue.
Things that went well :
The branch name is correct
The changes are correct
Things that need to change :
- What changes did you make? section needs to be more informative on where exactly the changes you made. i.e)
File updated: _projects/xxxxx
Where: xxxx on https://www.hackforla.org/projects/xxxx
Added the following: xxxxxx - Why did you make the changes? section should include more info. You could copy Overview section on the original issue.
- Check off CodeQL alerts on this issue.
Once you made changes, kindly update on this ticket. Thanks for your hard work!
|
Review ETA: 15 Jan 2025 @ 6 PM (GMT) |
There was a problem hiding this comment.
Hey @jmarinit, thanks for working on this!
Kudos
- The pull request is made with the correct branch.
- The pull request post contains a linked issue and the screenshots section is complete.
- The changes to the
_projects/open-community-survey.mdfile are accurate. - You have claimed the issue well and reported progress on the issue.
Suggested changes
Please make the following changes to the PR post:
- For the "What changes did you make?" section, try using backticks
(`)to enclose all filenames and code. For example,github-handleandopen-community-survey.md. - For the "What changes did you make?" section, please be more specific. You can use the "Overview" section of the originating issue to complete this.
- For the "CodeQL Alerts" section, please check off the relevant checkbox(es).
After making these changes, re-request a review from me. Feel free to reach out if you need help with anything.
Thank you for the feedback! I have made the relevant changes. |
handshek
left a comment
There was a problem hiding this comment.
@jmarinit Perfect!
- The branches from and to are setup correctly
- Link to the issue is included
- There is a clear and concise description of what was done and why
- No visual changes to the site, is mentioned
Thanks for working on this issue!
|
Hey @jmarinit, thanks for making the changes. This is yet to be completed:
Alternatively, you could update the "What changes did you make?" section as follows: In with Please let me know once you've made these changes. |
|
Review ETA: 6 PM 1/17/25 |
|
Hi @jmarinit, thank you for taking on this issue. Things that went well :
Things that need to change :
Thank you for your hard work! |
|
Thank you for working on this issue, @jmarinit Please review the changes requested by the reviewers and check the boxes if you made the corresponding changes. |
|
Review ETA: 21 Jan 2025 @ 8 PM (GMT) |
mugdhchauhan
left a comment
There was a problem hiding this comment.
Nice one @jmarinit, thanks for making the changes. I have approved this PR now. 👍
|
Hey @katiejnete, nice work on giving your PR review. It's posted as a comment rather than a review. Please remember to select yourself by clicking the gear icon from the "Reviewers" section on the top right. To do your PR review please go the "Files changed" tab, click on the green "Review changes" button, complete the appropriate sections and finally press the "Submit review" button. And to all reviewers please remember to provide your review ETA and availability. Thank you to everyone for working on this. |
katiejnete
left a comment
There was a problem hiding this comment.
Good job @jmarinit, thank you for making the changes. I approve this PR.
k-cardon
left a comment
There was a problem hiding this comment.
Code is accurate; I verified no issues in development environment. Thanks for your work! Will merge now.



Fixes #7433
What changes did you make?
In
_projects/open-community-survey.md, replaced:with
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)