Skip to content

Added github-handle for Mary Kate Leibman in open-community-survey.md#7822

Merged
k-cardon merged 1 commit intohackforla:gh-pagesfrom
jmarinit:add-github-handle-7433
Jan 22, 2025
Merged

Added github-handle for Mary Kate Leibman in open-community-survey.md#7822
k-cardon merged 1 commit intohackforla:gh-pagesfrom
jmarinit:add-github-handle-7433

Conversation

@jmarinit
Copy link
Member

@jmarinit jmarinit commented Jan 10, 2025

Fixes #7433

What changes did you make?

In _projects/open-community-survey.md, replaced:

- name: Mary Kate Leibman

with

- name: Mary Kate Leibman
  github-handle:

Why did you make the changes (we will use this info to test)?

  • We need to create a single variable github-handle to hold the github handle for each member of the leadership team. Eventually github-handle will replace the github and picture variables, reducing redundancy in the project file.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b jmarinit-add-github-handle-7433 gh-pages
git pull https://github.com/jmarinit/website.git add-github-handle-7433

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels Jan 10, 2025
@handshek handshek self-assigned this Jan 13, 2025
Copy link
Member

@handshek handshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jmarinit, great work!

There's just one small change to make: Instead of saying "It was requested in the issue," please provide the actual reason for the changes. You can check the overview section of the issue to understand why these changes were requested.

Ping me once you've made the changes, and I'll go ahead and approve your PR.

@mamypoco mamypoco self-requested a review January 13, 2025 19:11
Copy link
Member

@mamypoco mamypoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarinit, thank you for helping on this issue.

Things that went well :

The branch name is correct
The changes are correct

Things that need to change :

  • What changes did you make? section needs to be more informative on where exactly the changes you made. i.e)
    File updated: _projects/xxxxx
    Where: xxxx on https://www.hackforla.org/projects/xxxx
    Added the following: xxxxxx
  • Why did you make the changes? section should include more info. You could copy Overview section on the original issue.
  • Check off CodeQL alerts on this issue.

Once you made changes, kindly update on this ticket. Thanks for your hard work!

@mugdhchauhan
Copy link
Member

Review ETA: 15 Jan 2025 @ 6 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jmarinit, thanks for working on this!

Kudos

  • The pull request is made with the correct branch.
  • The pull request post contains a linked issue and the screenshots section is complete.
  • The changes to the _projects/open-community-survey.md file are accurate.
  • You have claimed the issue well and reported progress on the issue.

Suggested changes

Please make the following changes to the PR post:

  • For the "What changes did you make?" section, try using backticks (`) to enclose all filenames and code. For example, github-handle and open-community-survey.md.
  • For the "What changes did you make?" section, please be more specific. You can use the "Overview" section of the originating issue to complete this.
  • For the "CodeQL Alerts" section, please check off the relevant checkbox(es).

After making these changes, re-request a review from me. Feel free to reach out if you need help with anything.

@jmarinit
Copy link
Member Author

Hey @jmarinit, great work!

There's just one small change to make: Instead of saying "It was requested in the issue," please provide the actual reason for the changes. You can check the overview section of the issue to understand why these changes were requested.

Ping me once you've made the changes, and I'll go ahead and approve your PR.

Thank you for the feedback! I have made the relevant changes.

@jmarinit jmarinit requested a review from handshek January 16, 2025 06:38
Copy link
Member

@handshek handshek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarinit Perfect!

  • The branches from and to are setup correctly
  • Link to the issue is included
  • There is a clear and concise description of what was done and why
  • No visual changes to the site, is mentioned

Thanks for working on this issue!

@mugdhchauhan
Copy link
Member

mugdhchauhan commented Jan 16, 2025

Hey @jmarinit, thanks for making the changes.

This is yet to be completed:

  • For the "What changes did you make?" section, try using backticks (`) to enclose filenames and code. For example, github-handle and open-community-survey.md.

Alternatively, you could update the "What changes did you make?" section as follows:

In _projects/open-community-survey.md, replaced:

- name: Mary Kate Leibman

with

- name: Mary Kate Leibman
  github-handle:

Please let me know once you've made these changes.

@katiejnete
Copy link
Member

Review ETA: 6 PM 1/17/25
Availability: 6-8 PM some weekdays

@katiejnete
Copy link
Member

katiejnete commented Jan 17, 2025

Hi @jmarinit, thank you for taking on this issue.

Things that went well :

  • Pull request contains correct branch
  • Correct linked issue
  • Explained changes made and reasoning with enough detail
  • Pul request screenshots section is correct
  • Source code looks clean and follows guidelines

Things that need to change :

  • Small fix like using backticks (`) to format short snippets of code

Thank you for your hard work!

@siyunfeng
Copy link
Member

Thank you for working on this issue, @jmarinit

Please review the changes requested by the reviewers and check the boxes if you made the corresponding changes.
You can re-request the reviewers to review and approve your PR by clicking the recycle button in the Reviewers section on the right panel.

Screenshot of Re-request Review

@mugdhchauhan
Copy link
Member

Review ETA: 21 Jan 2025 @ 8 PM (GMT)
Availability: Daily @ 6 PM - 8 PM (GMT)

Copy link
Member

@mugdhchauhan mugdhchauhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @jmarinit, thanks for making the changes. I have approved this PR now. 👍

@mugdhchauhan
Copy link
Member

Hey @katiejnete, nice work on giving your PR review. It's posted as a comment rather than a review.

Please remember to select yourself by clicking the gear icon from the "Reviewers" section on the top right.

Screenshot 1

Screenshot 1

To do your PR review please go the "Files changed" tab, click on the green "Review changes" button, complete the appropriate sections and finally press the "Submit review" button.

Screenshot 2

Screenshot 2

And to all reviewers please remember to provide your review ETA and availability.

Thank you to everyone for working on this.

Copy link
Member

@mamypoco mamypoco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmarinit, thanks for update! I still suggest to mention the project URL and the information that no visual change is expected.
Anyways, I have approved this PR now!

@katiejnete katiejnete self-requested a review January 22, 2025 03:21
Copy link
Member

@katiejnete katiejnete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job @jmarinit, thank you for making the changes. I approve this PR.

Copy link
Member

@k-cardon k-cardon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is accurate; I verified no issues in development environment. Thanks for your work! Will merge now.

@k-cardon k-cardon merged commit f2036c7 into hackforla:gh-pages Jan 22, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Mary Kate Leibman in open-community-survey.md

7 participants