Skip to content

Updates not-today.md to add github-handle var for Jacquelin Coronilla#8140

Merged
daras-cu merged 1 commit intohackforla:gh-pagesfrom
ryanfkeller:update_not-today_md_jacquelin_coronilla_7782
May 21, 2025
Merged

Updates not-today.md to add github-handle var for Jacquelin Coronilla#8140
daras-cu merged 1 commit intohackforla:gh-pagesfrom
ryanfkeller:update_not-today_md_jacquelin_coronilla_7782

Conversation

@ryanfkeller
Copy link
Member

@ryanfkeller ryanfkeller commented May 14, 2025

Fixes #7782

What changes did you make?

  • Added a github-handle var to Jacquelin Coronilla's leadership team entry in not-today.md

Why did you make the changes (we will use this info to test)?

  • Part of preparing to replace github and picture variables with the singular github-handle var

CodeQL Alerts

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b ryanfkeller-update_not-today_md_jacquelin_coronilla_7782 gh-pages
git pull https://github.com/ryanfkeller/website.git update_not-today_md_jacquelin_coronilla_7782

@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) size: 0.25pt Can be done in 0.5 to 1.5 hours labels May 14, 2025
@andyvu923 andyvu923 self-requested a review May 16, 2025 02:27
Copy link
Member

@andyvu923 andyvu923 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ryanfkeller , thanks for working on this issue!

Things done well

  • Correct branches are used
  • PR links correct issue
  • Code changes are relevant and clean

Suggested Changes

No changes necessary for this PR. Only thing to mentions is that backticks ( ` ) can be used to enclose code variables or file names, such as not-today.md becoming not-today.md

Thanks for fixing this issue. PR Approved 👍👍

@santiseccovidal santiseccovidal requested a review from kdaca19xx May 18, 2025 17:16
@kdaca19xx
Copy link
Member

Availability: after 1pm (pacific)
ETA: 5/20

Copy link
Member

@kdaca19xx kdaca19xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, ryanfkeller!

Things Done Well

  • The pull request done with the correct branch.

  • There's a linked issue (and I understand it).

  • The change in the Files Changed tab looks good.

  • I appreciate your mention of the file, not-today.md.

Suggestions

none.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs ✅ waiting for merge team in P: HfLA Website: Project Board May 20, 2025
@daras-cu daras-cu merged commit 912969e into hackforla:gh-pages May 21, 2025
11 checks passed
@ryanfkeller ryanfkeller deleted the update_not-today_md_jacquelin_coronilla_7782 branch May 21, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Jacquelin Coronilla in not-today.md

4 participants