Add Citizen Engagement Example Page#8355
Merged
daras-cu merged 2 commits intohackforla:gh-pagesfrom Oct 4, 2025
Merged
Conversation
github-project-automation
bot
moved this to PR Needs review
in P: HfLA Website: Project Board
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
github-actions
bot
added
role: front end
Member
|
Member
|
Availability: 5-8PM Monday - Friday |
Member
|
Availability: 12 - 7 PM, Wednesday & Thursday |
myronchen-git
approved these changes
Oct 1, 2025
Member
There was a problem hiding this comment.
Good job on completing this small complexity issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The pull request title is named properly.
- The whats and whys in the pull request description is well written.
- The CodeQL alerts have been correctly checked off.
- Code changes have been correctly made.
- In the issue, you've properly checked off action items and gave your availability and ETA.
Other Notes
- For PRs, Hack for LA's convention is to have no assignees. I don't believe it will affect anything if there is one.
caz002
approved these changes
Oct 1, 2025
Member
caz002
left a comment
caz002
left a comment
There was a problem hiding this comment.
Thank you for working on this issue @Hiroeme !
Things Done Well
- PR description and images accurately describes changes and why they were made
- Only the files requested by the issue are changed, and website still functions as expected
- Correct issue is linked
- PR does not trigger any Code QL alerts and passes pipeline
Changes to Make
None
I approve this pull request.
github-project-automation
bot
moved this from PR Needs review
to PRs ✅ waiting for merge team
in P: HfLA Website: Project Board
santi-jose
approved these changes
Oct 2, 2025
Member
santi-jose
left a comment
santi-jose
left a comment
There was a problem hiding this comment.
Hi @Hiroeme good job working on this issue!
Things Done Well
- Pull request is done with the correct branch
- Issue is linked to PR
- Used descriptive title
- Made applicable changes requested by the issue
- Code was changed as requested by the issue
- Changes preserve the integrity of the website
- CodeQL Alerts properly checked
- What & Why sections of PR are answered
- Included pictures showing the changes affect the website
Changes to Make
- None
Nice work!
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8202
What changes did you make?
program-area-pages-cards.htmlcalledprogram-area-pages-cards-example.htmlin_includesdirectory.citizen-engagement.htmlcalledcitizen-engagement-example.htmlinpagesdirectory.citizen-engagement-example.htmlto include newly copiedprogram-area-pages-cards-example.htmlcontent.Why did you make the changes (we will use this info to test)?
citizen-engagement.htmlso that Quality Assurance (QA) can reference the original example page when making changes to the citizen engagement page.CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied
localhost:4000/citizen-engagement-examplebefore changes.Visuals after changes are applied
localhost:4000/citizen-engagement-exampleafter changes.