Skip to content

Added git-handle variable to Bonnie on website.md#8377

Merged
kdaca19xx merged 1 commit intohackforla:gh-pagesfrom
cadenramey:add-git-handle-bonnie-7382
Oct 26, 2025
Merged

Added git-handle variable to Bonnie on website.md#8377
kdaca19xx merged 1 commit intohackforla:gh-pagesfrom
cadenramey:add-git-handle-bonnie-7382

Conversation

@cadenramey
Copy link
Member

@cadenramey cadenramey commented Oct 20, 2025

Fixes #7382

What changes did you make?

  • Added git-handle variable to Bonnie on website

Why did you make the changes (we will use this info to test)?

  • Git-handle variable is going to be used to replace github and picture variables to make code more succinct.

CodeQL Alerts

After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.

Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown

Screenshot 2024-10-28 154514

Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.

  • I have checked this PR for CodeQL alerts and none were found.
  • I found CodeQL alert(s), and (select one):
    • I have resolved the CodeQL alert(s) as noted
    • I believe the CodeQL alert(s) is a false positive (Merge Team will evaluate)
    • I have followed the Instructions below, but I am still stuck (Merge Team will evaluate)
Instructions for resolving CodeQL alerts

If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.

In general, CodeQL alerts should be resolved prior to PR reviews and merging

Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)

  • No visual changes to the website

@github-actions
Copy link

Want to review this pull request? Take a look at this documentation for a step by step guide!


From your project repository, check out a new branch and test the changes.

git checkout -b cadenramey-add-git-handle-bonnie-7382 gh-pages
git pull https://github.com/cadenramey/website.git add-git-handle-bonnie-7382

@cadenramey cadenramey changed the title Completed issue 7382 - Added git-handle variable to Bonnie Completed issue #7382 - Added git-handle variable to Bonnie Oct 20, 2025
@github-actions github-actions bot added good first issue Good for newcomers role: front end Tasks for front end developers role: back end/devOps Tasks for back-end developers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) status: Updated No blockers and update is ready for review size: 0.25pt Can be done in 0.5 to 1.5 hours labels Oct 20, 2025
@MohamedTwahir
Copy link
Member

Review ETA: 9 PM 22/10/25
Availability: 3-5 PM Monday - Friday

Copy link
Member

@MohamedTwahir MohamedTwahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cadenramey
Everything looks good just a minor edit if possible for the merge team.
Why did you make the changes?
Try and rephrase it in your words as to why you made the changes maybe use contributing.md file as a guidance. But everything else seems solid.

@github-project-automation github-project-automation bot moved this from PR Needs review to PRs being reviewed in P: HfLA Website: Project Board Oct 22, 2025
Copy link
Member

@MohamedTwahir MohamedTwahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @cadenramey I will go ahead and approve this one for you.

Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work on completing this issue.


Done Correctly

  • The merge from and to branches have been correctly set.
  • The issue has been correctly linked.
  • The whats and whys in the pull request description have been filled out.
  • The CodeQL alerts have been correctly checked off.
  • Code changes have been correctly made.
  • In the issue, you've correctly assigned yourself.
  • In the issue, the project and its status has been correctly assigned.

Changes that need to be made

  • The pull request title should not contain the issue number that you are working on. The "Completed issue #7382 -" part should be removed, and maybe a few more words can be added to specify where the change is made.

    You can review this part of the How to contribute wiki for an explanation of what I am talking about.


Optional recommendations

  • In the issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.

@cadenramey cadenramey changed the title Completed issue #7382 - Added git-handle variable to Bonnie Added git-handle variable to Bonnie on contributing.md Oct 23, 2025
@myronchen-git
Copy link
Member

myronchen-git commented Oct 23, 2025

contributing.md would be the wrong location.

@cadenramey cadenramey changed the title Added git-handle variable to Bonnie on contributing.md Added git-handle variable to Bonnie on website.md Oct 23, 2025
Copy link
Member

@myronchen-git myronchen-git left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job. Everything looks fine now.

@github-project-automation github-project-automation bot moved this from PRs being reviewed to PRs ✅ waiting for merge team in P: HfLA Website: Project Board Oct 24, 2025
@kdaca19xx kdaca19xx merged commit 7e494c0 into hackforla:gh-pages Oct 26, 2025
22 of 30 checks passed
@cadenramey cadenramey removed the status: Updated No blockers and update is ready for review label Oct 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue Good for newcomers P-Feature: Project Info and Page A project's detail page (e.g. https://www.hackforla.org/projects/100-automations) role: back end/devOps Tasks for back-end developers role: front end Tasks for front end developers size: 0.25pt Can be done in 0.5 to 1.5 hours

Projects

Development

Successfully merging this pull request may close these issues.

Add github-handle for Bonnie Wolfe in _projects/website.md

4 participants