Added git-handle variable to Bonnie on website.md#8377
Added git-handle variable to Bonnie on website.md#8377kdaca19xx merged 1 commit intohackforla:gh-pagesfrom
Conversation
|
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes. |
|
Review ETA: 9 PM 22/10/25 |
MohamedTwahir
left a comment
There was a problem hiding this comment.
Hi @cadenramey
Everything looks good just a minor edit if possible for the merge team.
Why did you make the changes?
Try and rephrase it in your words as to why you made the changes maybe use contributing.md file as a guidance. But everything else seems solid.
MohamedTwahir
left a comment
There was a problem hiding this comment.
Great job @cadenramey I will go ahead and approve this one for you.
myronchen-git
left a comment
There was a problem hiding this comment.
Good work on completing this issue.
Done Correctly
- The merge from and to branches have been correctly set.
- The issue has been correctly linked.
- The whats and whys in the pull request description have been filled out.
- The CodeQL alerts have been correctly checked off.
- Code changes have been correctly made.
- In the issue, you've correctly assigned yourself.
- In the issue, the project and its status has been correctly assigned.
Changes that need to be made
-
The pull request title should not contain the issue number that you are working on. The "
Completed issue #7382 -" part should be removed, and maybe a few more words can be added to specify where the change is made.You can review this part of the How to contribute wiki for an explanation of what I am talking about.
Optional recommendations
- In the issue, you didn't give your availability and ETA. You can put that in now for completeness, but you should get into the habit of giving them after you've assigned yourself, even if you are able to complete the work in a few hours.
|
|
myronchen-git
left a comment
There was a problem hiding this comment.
Good job. Everything looks fine now.
Fixes #7382
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)