Cover photo dimensions should be 16/9 #535
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Hey @Eficnbo, same ask here as well. This one is a slightly bigger change but hopefully easy to read. Thanks! |
Collaborator
Author
|
Hey @Eficnbo, could you take a look at and merge this and the next couple of PRs so they don't go stale? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the image ratio settings and design of the event cover photo. The current issue is that even though the dashboard recommends admins to upload a 1920x1080 picture, this image is reformatted into multiple aspect ratios and is used as a full width cover photo, resulting in bad looking event pages and non-visible text.
This PR changes the layout of the event detail page so that the cover photo can maintain a fixed aspect ratio. Further, it also updates the EventCard so it also respects this ratio if possible.
Event detail page with card-like cover photo (all corners visible):
Scales to full width on mobile:
Corners visible on EventCard:
Cover photo is center aligned on project gallery page:
Works nicely with a customized event page:
