Fix/organizer-dashboard. Allow organizer to preview the Event page customization through a modal #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewModal component to show preview of customized event page
…ge customizations
…ug/index page, subject to modification for preview only purposes
…EventPageCustomizationPreviewModal inside _organize/slug/edit/default component
…inside _organize/slug/edit/default component as the EventPagePreview component will be directly rendered in the modal
…eters to read and set Preview mode
… deatil preview modal
…ton based on state
Contributor
Author
|
wickathou
reviewed
Feb 27, 2024
Collaborator
There was a problem hiding this comment.
Hi @davidamebley ,
Well done! 🎉
Your solution works well, and it is scheduled for merge on February 28th
Highlights
- Clean solution to the problem
Optional suggestions
- The preview doesn't show new colors selected by the user, unless they save their color choices. It would be a better user experience if the colors selected could be previewed without having to save
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
wickathou
added a commit
that referenced
this pull request
Apr 11, 2024
Update - Bringing #770 with merge conflicts solved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a modal that allows the organizer to preview the Event page customization without leaving the current page.