RE Fix - Improved performance of finalist voting #839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nc function Removed commented code Added new winner votes controller function getFinalistProjectsWithAllVotes to return finalist projects with the votes received Removed sorting from getVotesForEvent function in the winner votes controller Modified structure of winner votes routes file to be more readable Deleted unused files Modified projects/winners page to show results sorted from highest to lowest vote count and improved performance by making only one call to the backend Modified participant/finalist-voting page to be readable and reduced the amount of calls done to the backend
wickathou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes