Configurable default break style #1306
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
When `RevealMarkdown.initialize` is called, it use `md.render` to render markdown, but no until we parse meta, the md.options.breaks would be default value we set in extra.js. So this commit move forward the whole meta parsing block. Ensure line break setting changed before `md.render` get called. Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
Yukaii
force-pushed
the
feature/configurable-break-style
branch
from
8db1d04 to
56b669a
Compare
Signed-off-by: Yukai Huang <yukaihuangtw@gmail.com>
Member
|
LGTM, thanks @Yukaii |
jackycute
approved these changes
Nov 1, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1212
Changes
This PR introduce a new configuration entry let you follow CommonMark spec break behavior:
config.defaultUseHardbreaktotrue(Current CodiMD implementation)
config.defaultUseHardbreaktofalse(CommonMark)
Notice that we keep the default
defaultUseHardbreakvalue totruefor preserving the current behavior.TODOs
Ref