Skip to content

Fix slide mode stored XSS #1650

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Yukaii merged 2 commits into from
Jan 25, 2021
Merged

Fix slide mode stored XSS #1650

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9291a76
fix: properly escape reveal markdown script tag with case-insensitive…
jackycute Jan 21, 2021
c47f0f0
fix: remove reveal options of dependencies which allow import user de…
jackycute Jan 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion public/js/reveal-markdown.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ import { md } from './extra'

// prevent script end tags in the content from interfering
// with parsing
content = content.replace(/<\/script>/g, SCRIPT_END_PLACEHOLDER)
content = content.replace(/<\/script>/gi, SCRIPT_END_PLACEHOLDER)

return '<script type="text/template">' + content + '</script>'
}
Expand Down
2 changes: 2 additions & 0 deletions public/js/slide.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,8 @@ const defaultOptions = {
}

var options = meta.slideOptions || {}
// delete dependencies to avoid import user defined external resources
delete options.dependencies

if (Object.hasOwnProperty.call(options, 'spotlight')) {
defaultOptions.dependencies.push({
Expand Down